Review main Merged

86522[TASK] Get FlexFormTools injected via DI

Anja Leichsenring CR +2 V +2 Normal +106 −116 updated 11/21/24, 18:17

Commit message

FlexFormTools stateless and shared. It can be injected
at more places rather easily.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2232

Show 57 earlier messages
  1. Anja Leichsenring uploaded patch set 1 10/08/24, 17:20

  2. core-ci voted on patch set 1 V -1 10/08/24, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67395

  3. Anja Leichsenring uploaded patch set 2 V -1 10/08/24, 18:01

  4. core-ci voted on patch set 2 V +1 10/08/24, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67396

  5. Martin Adler commented on patch set 2 CR +1 10/10/24, 07:40

    RelationMapBuilder.php:35

    @aleichsenring@ab-softlab.de Isn't this readonly property redundant since the class is already declared readonly?
  6. Christian Kuhn commented on patch set 2 CR -1 10/11/24, 07:35

    FlexFormValueFormatter.php:39

    This will break ElementHistoryController.
  7. Anja Leichsenring uploaded patch set 3 CR +1 V +1 10/16/24, 07:49

  1. Anja Leichsenring commented on patch set 3 10/16/24, 07:50

    FlexFormValueFormatter.php:39 Reply

    Done
  2. core-ci voted on patch set 3 V +1 10/16/24, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67870

  3. Martin Adler commented on patch set 3 10/16/24, 08:27

    RelationMapBuilder.php:35 Reply

    Done
  4. Anja Leichsenring uploaded patch set 4 V +1 10/16/24, 14:03

  5. core-ci voted on patch set 4 V +1 10/16/24, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67886

  6. Anja Leichsenring uploaded patch set 5 V +1 11/08/24, 08:37

  7. core-ci voted on patch set 5 V -1 11/08/24, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69222

  8. Christian Kuhn commented on patch set 5 11/21/24, 15:08

    FlexFormTools *is* shared?!
  9. Christian Kuhn commented on patch set 5 11/21/24, 15:27

    FlexFormValueFormatter.php:35

    it might be more easy and more transparent when we handle FlexFormValueFormatter in a dedicated patch first. I'll try to come up with something.
  10. Christian Kuhn uploaded patch set 6 V -1 11/21/24, 16:44

  11. Christian Kuhn commented on patch set 6 11/21/24, 16:44

    FlexFormValueFormatter.php:35 Reply

    Done
  12. Christian Kuhn uploaded patch set 7 11/21/24, 16:44

  13. core-ci voted on patch set 6 V -1 11/21/24, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69966

  14. core-ci voted on patch set 7 V +1 11/21/24, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69967

  15. Christian Kuhn uploaded patch set 8 V +1 11/21/24, 16:56

  16. Christian Kuhn updated the commit message in patch set 9 11/21/24, 16:57

  17. Christian Kuhn commented on patch set 6 11/21/24, 16:57

    Reply

    Done
  18. core-ci voted on patch set 8 V -1 11/21/24, 17:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69968

  19. core-ci voted on patch set 9 V -1 11/21/24, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69969

  20. Christian Kuhn uploaded patch set 10 V -1 11/21/24, 17:38

  21. core-ci voted on patch set 10 V +1 11/21/24, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69973

  22. Oli Bartsch voted on patch set 10 CR +1 V +1 11/21/24, 17:56

  23. Andreas Nedbal voted on patch set 10 CR +1 V +1 11/21/24, 18:13

  24. Christian Kuhn voted on patch set 10 CR +2 V +2 11/21/24, 18:17

  25. Christian Kuhn merged patch set 11 11/21/24, 18:17