86522[TASK] Get FlexFormTools injected via DI
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Andreas Nedbal +1
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Andreas Nedbal +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/Resource/StorageRepository.php+5 −6
- typo3/sysext/core/Classes/Schema/RelationMapBuilder.php2+6 −4
- typo3/sysext/core/Classes/ServiceProvider.php+3 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Domain/RecordFactoryTest.php+4 −3
- typo3/sysext/core/Tests/Unit/Resource/StorageRepositoryTest.php+7 −1
- typo3/sysext/core/Tests/Unit/Schema/TcaSchemaFactoryTest.php+13 −4
- typo3/sysext/impexp/Classes/Import.php+9 −8
- typo3/sysext/impexp/Tests/Functional/Command/ImportCommandTest.php+5 −6
- typo3/sysext/impexp/Tests/Functional/Utility/ImportExportUtilityTest.php+4 −15
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+49 −68
Review log 2232
Show 57 earlier messages
-
Anja Leichsenring uploaded patch set 1 10/08/24, 17:20
-
core-ci voted on patch set 1 V -1 10/08/24, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67395
-
Anja Leichsenring uploaded patch set 2
V -110/08/24, 18:01 -
core-ci voted on patch set 2 V +1 10/08/24, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67396
-
Martin Adler commented on patch set 2 CR +1 10/10/24, 07:40
-
Christian Kuhn commented on patch set 2 CR -1 10/11/24, 07:35
FlexFormValueFormatter.php:39This will break ElementHistoryController. -
Anja Leichsenring uploaded patch set 3
CR +1V +110/16/24, 07:49
-
Anja Leichsenring commented on patch set 3 10/16/24, 07:50
FlexFormValueFormatter.php:39ReplyDone -
core-ci voted on patch set 3 V +1 10/16/24, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67870
-
Martin Adler commented on patch set 3 10/16/24, 08:27
RelationMapBuilder.php:35ReplyDone -
Anja Leichsenring uploaded patch set 4
V +110/16/24, 14:03 -
core-ci voted on patch set 4 V +1 10/16/24, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67886
-
Anja Leichsenring uploaded patch set 5
V +111/08/24, 08:37 -
core-ci voted on patch set 5 V -1 11/08/24, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69222
-
Christian Kuhn commented on patch set 5 11/21/24, 15:08
FlexFormTools *is* shared?! -
Christian Kuhn commented on patch set 5 11/21/24, 15:27
FlexFormValueFormatter.php:35it might be more easy and more transparent when we handle FlexFormValueFormatter in a dedicated patch first. I'll try to come up with something. -
Christian Kuhn uploaded patch set 6
V -111/21/24, 16:44 -
Christian Kuhn commented on patch set 6 11/21/24, 16:44
FlexFormValueFormatter.php:35ReplyDone -
Christian Kuhn uploaded patch set 7 11/21/24, 16:44
-
core-ci voted on patch set 6 V -1 11/21/24, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69966
-
core-ci voted on patch set 7 V +1 11/21/24, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69967
-
Christian Kuhn uploaded patch set 8
V +111/21/24, 16:56 -
Christian Kuhn updated the commit message in patch set 9 11/21/24, 16:57
-
Christian Kuhn commented on patch set 6 11/21/24, 16:57
Reply
Done -
core-ci voted on patch set 8 V -1 11/21/24, 17:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69968
-
core-ci voted on patch set 9 V -1 11/21/24, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69969
-
Christian Kuhn uploaded patch set 10
V -111/21/24, 17:38 -
core-ci voted on patch set 10 V +1 11/21/24, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69973
-
Oli Bartsch voted on patch set 10 CR +1 V +1 11/21/24, 17:56
-
Andreas Nedbal voted on patch set 10 CR +1 V +1 11/21/24, 18:13
-
Christian Kuhn voted on patch set 10 CR +2 V +2 11/21/24, 18:17
-
Christian Kuhn merged patch set 11 11/21/24, 18:17
RelationMapBuilder.php:35