Review main Merged

86523[TASK] Stabilize ElementsGroupCest by waiting for modal-iframe load

Ayke Halder CR +2 V +2 Easy +19 −9 updated 10/10/24, 18:36

Commit message

This makes ElementsGroupCest wait, until the modal-iframe is loaded and
the new "block formatting context" (BFC)  is created, before filling any
data into the search field. About BFC also see [1] and [2].

Before this change the search field was sporadically empty on send,
even though no error for `$I->fillField(…)` was triggered.

Additionally this makes some CSS-selectors more specific.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/overflow#description
[2] https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_display/Block_formatting_context

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Ayke Halder uploaded patch set 1 10/08/24, 19:22

  2. core-ci voted on patch set 1 V +1 10/08/24, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67397

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 10/10/24, 06:24

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 10/10/24, 17:47

  5. Stefan Bürk merged patch set 2 10/10/24, 18:36