Review main Abandoned

86525[TASK] Inject code editor services in FormEngine elements

Oli Bartsch CR 0 V 0 Normal +40 −27 updated 04/24/25, 14:17

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 912

  1. Oli Bartsch uploaded patch set 1 10/09/24, 08:06

  2. core-ci voted on patch set 1 V -1 10/09/24, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67415

  3. Oli Bartsch uploaded patch set 2 V -1 10/09/24, 09:08

  4. core-ci voted on patch set 2 V +1 10/09/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67429

  5. Oli Bartsch commented on patch set 2 CR -1 10/09/24, 14:02

    Will work on this again.
  6. Benni Mack marked it work in progress 03/22/25, 12:32

  7. Oli Bartsch uploaded patch set 3 CR -1 V +1 04/24/25, 12:19

  8. core-ci voted on patch set 3 V +1 04/24/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78125

  9. Oli Bartsch marked it ready for review 04/24/25, 13:31

  10. Oli Bartsch commented on patch set 3 04/24/25, 13:31

    Reply

    Done
  11. Christian Kuhn commented on patch set 3 CR -1 04/24/25, 13:44

    hmm. i don't think we should do this at all in the current form: the patch proposes to DI stateful services, with does not improve the overall situation. It looks as if the bundle CodeEditor - ModeRegistry - AddonRegistry should receive a proper overhaul instead: Maybe a stateless factory that could do the caching combined with a couple of find* methods to return what is needed? At the moment, the stateful singletons are just awful, and adding DI to this mess does not really help us. What do you think?
  12. Oli Bartsch abandoned the change 04/24/25, 14:17

    Needs a more sophisticated approach