Review main Merged

86526[BUGFIX] Suspend FormEngine validation on record type change

Andreas Kienast CR +2 V +2 Normal +56 −58 updated 10/11/24, 13:13

Commit message

If a user attempts to change a record type, the backend user is asked to
save the form as it needs to get re-rendered. This will trigger the
FormEngine validation. If a user decided to leave out a field on
purpose, because it's not relevant in the new record type, FormEngine
validation will fail and stop the request, asking the user to fulfill
the field's constraints.

Example:

1. User creates a new "Page" record of type "External URL" by accident
2. User wants to switch to "Shortcut"
3. User has to fill the field "URL", even if it's not required by
   "Shortcut"

FormEngine validation currently has no sustainable solution for this
scenario. One solution could be to check whether the field *will be*
required in the new record type nevertheless.

This issue may cause major pain to editors. To workaround this issue for
now, validation is completely suspended when a FormEngine update has
been requested.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 89

  1. Andreas Kienast uploaded patch set 1 10/09/24, 08:17

  2. Andreas Kienast updated the commit message in patch set 2 10/09/24, 08:17

  3. Andreas Kienast uploaded patch set 3 10/09/24, 08:18

  4. Andreas Kienast uploaded patch set 4 10/09/24, 08:20

  5. core-ci voted on patch set 4 V +1 10/09/24, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67421

  6. Benjamin Franzke voted on patch set 4 CR +1 V +1 10/10/24, 16:55

  7. Frank Nägler voted on patch set 4 CR +1 V +1 10/11/24, 13:13

  8. Andreas Kienast voted on patch set 4 CR +2 V +2 10/11/24, 13:13

  9. Andreas Kienast merged patch set 5 10/11/24, 13:13