Review main Merged

86527[TASK] Instantiate JavaScriptItems with new()

Christian Kuhn CR +2 V +2 Normal +35 −60 updated 10/09/24, 10:08

Commit message

Class TYPO3\CMS\Core\Page\JavaScriptItems is a DTO.
It is a contract between PHP and JS with some
functionality on the PHP side to gather and prepare
the data to transfer and to park state on PHP side.
As such, this class can not be extended by extensions
since that would break the contract.
The patch thus declares the class final and changes
instantiation to use new().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 710

  1. Christian Kuhn uploaded patch set 1 10/09/24, 08:18

  2. core-ci voted on patch set 1 V +1 10/09/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67419

  3. Christian Kuhn updated the commit message in patch set 2 V +1 10/09/24, 08:48

  4. core-ci voted on patch set 2 V +1 10/09/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67424

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 10/09/24, 09:04

  6. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 10/09/24, 09:44

  7. Garvin Hicking commented on patch set 3 CR +1 V +1 10/09/24, 09:45

    OK for me since it's "obviously" intended to be an internal contract.
  8. core-ci voted on patch set 3 V +1 10/09/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67433

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 10/09/24, 10:08

  10. Christian Kuhn merged patch set 4 10/09/24, 10:08