86527[TASK] Instantiate JavaScriptItems with new()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php+3 −3
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+3 −3
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+2 −2
- typo3/sysext/core/Classes/Page/AssetRenderer.php+5 −16
- typo3/sysext/core/Classes/Page/ImportMapCacheWarmer.php+4 −7
- typo3/sysext/core/Classes/Page/ImportMapFactory.php+6 −6
- typo3/sysext/core/Classes/Page/JavaScriptItems.php+1 −1
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+7 −1
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+3 −20
Review log 710
-
Christian Kuhn uploaded patch set 1 10/09/24, 08:18
-
core-ci voted on patch set 1 V +1 10/09/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67419
-
Christian Kuhn updated the commit message in patch set 2
V +110/09/24, 08:48 -
core-ci voted on patch set 2 V +1 10/09/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67424
-
Stefan Bürk voted on patch set 2 CR +1 V +1 10/09/24, 09:04
-
Garvin Hicking updated the commit message in patch set 3
CR +1V +110/09/24, 09:44 -
Garvin Hicking commented on patch set 3 CR +1 V +1 10/09/24, 09:45
OK for me since it's "obviously" intended to be an internal contract. -
core-ci voted on patch set 3 V +1 10/09/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67433
-
Christian Kuhn voted on patch set 3 CR +2 V +2 10/09/24, 10:08
-
Christian Kuhn merged patch set 4 10/09/24, 10:08