Review 12.4 Merged

86528[BUGFIX] Fix pagetree subtree expansion in search mode

Benjamin Franzke CR +2 V +2 Normal +63 −4 updated 10/10/24, 07:04

Commit message

The TreeController was adapted with #104397 to reduce possibly
unneeded getTreeLevels calls and refactored the condition that
sets the hasChildren flag on a node object.
It turns out that this caused search queries to miss the
hasChildren flag, as the depth pre-condition always evaluated
to false (treeLevelsToFetch is 999 is search-mode).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 911

  1. Benjamin Franzke uploaded patch set 1 10/09/24, 08:33

  2. core-ci voted on patch set 1 V -1 10/09/24, 08:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67422

  3. Oliver Hader commented on patch set 1 10/09/24, 10:38

    TreeControllerTest.php:817

    `filterDataAction`
  4. Oliver Hader uploaded patch set 2 V -1 10/09/24, 10:38

  5. Oliver Hader commented on patch set 2 10/09/24, 10:39

    TreeControllerTest.php:817 Reply

    Done
  6. core-ci voted on patch set 2 V +1 10/09/24, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67437

  7. Benjamin Franzke commented on patch set 2 10/09/24, 10:51

    TreeControllerTest.php:817 Reply

    🤦 sorry
  8. Benjamin Franzke marked it ready for review 10/09/24, 11:44

  9. Oliver Hader voted on patch set 2 CR +1 10/09/24, 20:54

  10. Benjamin Franzke voted on patch set 2 CR +2 V +2 10/10/24, 07:04

  11. Benjamin Franzke merged patch set 3 10/10/24, 07:04