Review main Merged

86529[TASK] De-duplicate type update confirmation

Andreas Kienast CR +2 V +2 Normal +51 −134 updated 10/16/24, 08:34

Commit message

In 2021 the FormEngine reload mechanism was reworked to trigger the
confirmation via a custom web component. This is not necessary anymore,
as half a year later the `ReloadOnFieldChange` form behavior class was
introduced.

This commit removes the custom web component in favor of
`ReloadOnFieldChange`, de-duplicating the logic and removing the need to
load additional assets.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 811

  1. Andreas Kienast uploaded patch set 1 10/09/24, 08:55

  2. core-ci voted on patch set 1 V +1 10/09/24, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67426

  3. Andreas Kienast updated the commit message in patch set 2 V +1 10/09/24, 09:07

  4. core-ci voted on patch set 2 V +1 10/09/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67428

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 10/11/24, 08:12

  6. Andreas Kienast uploaded patch set 3 CR +1 V +1 10/11/24, 13:15

  7. core-ci voted on patch set 3 V +1 10/11/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67598

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 10/11/24, 14:01

  9. Anja Leichsenring voted on patch set 3 CR +1 V +1 10/16/24, 07:01

  10. Andreas Kienast voted on patch set 3 CR +2 V +2 10/16/24, 08:33

  11. Andreas Kienast merged patch set 4 10/16/24, 08:34