Review main Merged

86530[TASK] Inject services in FormEngine data providers

Oli Bartsch CR +2 V +2 Hard +406 −199 updated 10/10/24, 09:49

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 35

Show 15 more files

Review log 1319

  1. Oli Bartsch uploaded patch set 1 10/09/24, 09:05

  2. core-ci voted on patch set 1 V -1 10/09/24, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67427

  3. Stefan Bürk commented on patch set 1 10/09/24, 11:08

    Services.php:26

    Should it not be possible to solve this by php attribute on the FormDataProviderInterface directly ? ``` #[AutoconfigureTag('backend.form.dataprovider')] ```
  4. Oli Bartsch uploaded patch set 2 V -1 10/09/24, 14:16

  5. Oli Bartsch uploaded patch set 3 10/09/24, 14:18

  6. Oli Bartsch commented on patch set 3 10/09/24, 14:18

    Services.php:26 Reply

    Done
  7. core-ci voted on patch set 2 V -1 10/09/24, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67450

  8. core-ci voted on patch set 3 V -1 10/09/24, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67451

  9. Oli Bartsch uploaded patch set 4 V -1 10/10/24, 07:05

  10. core-ci voted on patch set 4 V +1 10/10/24, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67477

  11. Oli Bartsch uploaded patch set 5 V +1 10/10/24, 07:15

  12. core-ci voted on patch set 5 V +1 10/10/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67479

  13. Christian Kuhn commented on patch set 5 CR -1 10/10/24, 08:51

    on it.
  14. Christian Kuhn uploaded patch set 6 CR -1 V +1 10/10/24, 08:57

  15. core-ci voted on patch set 6 V +1 10/10/24, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67486

  16. Christian Kuhn voted on patch set 6 CR +1 V +1 10/10/24, 09:33

  17. Stefan Bürk voted on patch set 6 CR +1 V +1 10/10/24, 09:44

  18. Oli Bartsch voted on patch set 6 CR +2 V +2 10/10/24, 09:48

  19. Oli Bartsch merged patch set 7 10/10/24, 09:49