Review main Merged

86531[BUGFIX] Prevent collapse state issues in pagetree filter

Benjamin Franzke CR +2 V +2 Normal +45 −54 updated 10/11/24, 06:49

Commit message

The pagetree has been changed to store collapse state in
local storage with #10528 but failed to adapt the state
handling for the filter mode, which caused pages to be
rendered without children but bing shows as being expanded.
This means the currently collapsed page had to be clicked
twice to toggle the state twice and to show children.

Also remove any backend code that is a left-over from the
backend-side state handling (UC) and instead calculate
`expanded` (now renamed to `__expanded` to reflect that it
is a client-side calculated property, synchronized with local
storage).

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 15

Review log 57

  1. Benjamin Franzke uploaded patch set 1 10/09/24, 09:09

  2. core-ci voted on patch set 1 V -1 10/09/24, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67430

  3. Benjamin Franzke uploaded patch set 2 V -1 10/09/24, 09:26

  4. core-ci voted on patch set 2 V +1 10/09/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67431

  5. Benjamin Kott voted on patch set 2 CR +1 V +1 10/11/24, 06:33

  6. Andreas Kienast voted on patch set 2 CR +2 V +2 10/11/24, 06:49

  7. Andreas Kienast merged patch set 3 10/11/24, 06:49