Review main Merged

86534[TASK] Turn DataProviderContext into a PCPP DO

Christian Kuhn CR +2 V +2 Normal +178 −24 updated 10/09/24, 15:05

Commit message

DataProviderContext is a DO hand over to single backend
layout providers. This is state that should be hand over
and must not be injected, using SingletonInterface is an
anti-pattern with this class.

The patch:
* Removes SingletonInterface
* Introduces PCPP and instantiates with new()
* Declares final
* Deprecates all getters and setters
* Prepares the class to be set readonly in TYPO3 v14
* Adapts usages
* Adds a deprecation ReST

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 810

  1. Christian Kuhn uploaded patch set 1 10/09/24, 10:45

  2. core-ci voted on patch set 1 V +1 10/09/24, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67439

  3. Christian Kuhn uploaded patch set 2 V +1 10/09/24, 11:17

  4. core-ci voted on patch set 2 V +1 10/09/24, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67443

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 10/09/24, 11:45

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 10/09/24, 11:48

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 10/09/24, 11:53

  8. Christian Kuhn merged patch set 3 10/09/24, 11:53

  9. Benjamin Franzke commented on patch set 2 10/09/24, 11:55

    btw, the first `P` is ambiguous, is private, protected or public? :D I know, we already made this mistake in https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CodingBestPractices/NamedArguments.html#utilizing-named-arguments-in-extensions (as I just noticed when searching for PCPP on google)
  10. Christian Kuhn commented on patch set 3 10/09/24, 15:05

    Reply

    ack. that abbreviation did fix so nicely as commit title ;) *we* know this is for 'public' (and the full phrase is used in .rst), but we may want to switch to use "public CPP" instead. will try to do that in future patches.