Review 11.5 Merged

86535[BUGFIX] Fix pagetree subtree expansion in search mode

Benjamin Franzke CR +2 V +2 Normal +65 −4 updated 10/10/24, 07:04

Commit message

The TreeController was adapted with #104397 to reduce possibly
unneeded getTreeLevels calls and refactored the condition that
sets the hasChildren flag on a node object.
It turns out that this caused search queries to miss the
hasChildren flag, as the depth pre-condition always evaluated
to false (treeLevelsToFetch is 999 is search-mode).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 710

  1. Benjamin Franzke uploaded patch set 1 10/09/24, 10:54

  2. core-ci voted on patch set 1 V -1 10/09/24, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67440

  3. Benjamin Franzke uploaded patch set 2 V -1 10/09/24, 11:06

  4. Benjamin Franzke uploaded patch set 3 10/09/24, 11:09

  5. core-ci voted on patch set 2 V -1 10/09/24, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67441

  6. core-ci voted on patch set 3 V +1 10/09/24, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67442

  7. Benjamin Franzke marked it ready for review 10/09/24, 11:44

  8. Oliver Hader voted on patch set 3 CR +1 10/09/24, 20:54

  9. Benjamin Franzke voted on patch set 3 CR +2 V +2 10/10/24, 07:04

  10. Benjamin Franzke merged patch set 4 10/10/24, 07:04