Review main Merged

86536[TASK] Clean up DefaultDataProvider

Christian Kuhn CR +2 V +2 Normal +48 −51 updated 10/09/24, 14:25

Commit message

Backend layout DefaultDataProvider receives some love:
* Use DI and declare public:true since single backend
  layout data providers are created using GU::makeInstance().
* Relocate @internal BackendLayoutView::getDefaultColumnLayout()
  to a private constant of DefaultDataProvider.
* Annotate DefaultDataProvider @internal since it is an
  interface implementing leaf class that should not be extended
  but exchanged using existing API.
* Declare DefaultDataProvider readonly since it is now
  a stateless service.
* Inline tableName property (a de facto constant) that is
  already hard coded at other places.
* Avoid a silent catch that would trigger an exception at another
  place and add a @todo hinting about an indirect ext:backend
  cross dependency to ext:frontend.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Christian Kuhn uploaded patch set 1 10/09/24, 12:15

  2. core-ci voted on patch set 1 V +1 10/09/24, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67445

  3. Christian Kuhn uploaded patch set 2 V +1 10/09/24, 12:32

  4. Christian Kuhn updated the commit message in patch set 3 10/09/24, 12:36

  5. core-ci voted on patch set 2 V -1 10/09/24, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67446

  6. core-ci voted on patch set 3 V +1 10/09/24, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67447

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 10/09/24, 12:53

  8. Oli Bartsch voted on patch set 3 CR +1 V +1 10/09/24, 14:23

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 10/09/24, 14:24

  10. Christian Kuhn merged patch set 4 10/09/24, 14:25