Review main Merged

86537[TASK] Use DI in TranslationConfigurationProvider

Christian Kuhn CR +2 V +2 Normal +63 −49 updated 10/10/24, 08:43

Commit message

* Use runtimeCache instead of a class cache property
* Declare readonly
* DI dependent services
* Declare some safe to set types
* Adapt tests
* Fix a broken test in BackendUtilityTest that used
  backendUser and global language object before
  site configuration has been written

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Christian Kuhn uploaded patch set 1 10/09/24, 13:36

  2. core-ci voted on patch set 1 V -1 10/09/24, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67448

  3. Christian Kuhn uploaded patch set 2 V -1 10/09/24, 14:24

  4. core-ci voted on patch set 2 V +1 10/09/24, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67452

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 10/09/24, 14:41

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 10/10/24, 08:42

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 10/10/24, 08:43

  8. Christian Kuhn merged patch set 3 10/10/24, 08:43