86541[BUGFIX] Ensure flexform data only contains a string or array
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1623
-
Ayke Halder uploaded patch set 1 10/09/24, 17:30
-
core-ci voted on patch set 1 V -1 10/09/24, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67459
-
Ayke Halder uploaded patch set 2
V -110/09/24, 17:59 -
core-ci voted on patch set 2 V +1 10/09/24, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67461
-
Oli Bartsch commented on patch set 2 10/10/24, 04:46
-
Mathias Brodala commented on patch set 2 10/10/24, 06:38
FormPagePreviewRenderer.php:66You should use get_debug_type() instead here so that one gets the FQCN in case of "object". Also the leading backslash should be dropped as this pattern is not used in TYPO3. -
Ayke Halder uploaded patch set 3
V +110/10/24, 09:27 -
Ayke Halder uploaded patch set 4 10/10/24, 09:29
-
core-ci voted on patch set 3 V +1 10/10/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67488
-
Ayke Halder commented on patch set 4 10/10/24, 09:36
FormPagePreviewRenderer.php:64ReplyThe "missing flexform" case is already handled by: `$flexFormData = $row['pi_flexform'] ?? [];` So there is/was no exception/logging for missing flexform. ---- About the severity of invalid flexform data: No exception is thrown anymore. Instead this gets just logged as warning and the flexform data is set to the default empty array.FormPagePreviewRenderer.php:66ReplyAcknowledged -
core-ci voted on patch set 4 V +1 10/10/24, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67489
-
Oliver Hader updated the commit message in patch set 5
V +110/18/24, 13:59 -
Oliver Hader rebased onto patch set 6 11/15/24, 08:42
-
core-ci voted on patch set 6 V +1 11/15/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69462
-
Oli Bartsch updated the commit message in patch set 7
V +111/15/24, 10:41 -
Oli Bartsch voted on patch set 7 CR +1 V +1 11/15/24, 10:41
-
core-ci voted on patch set 7 V +1 11/15/24, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69471
-
Ayke Halder updated the commit message in patch set 8
CR +1V +111/15/24, 13:53 -
core-ci voted on patch set 8 V +1 11/15/24, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69485
-
Benni Mack voted on patch set 8 CR +2 V +2 11/15/24, 16:53
-
Benni Mack voted on patch set 8 CR +1 V +1 11/15/24, 16:53
-
Oli Bartsch voted on patch set 8 CR +2 V +2 11/15/24, 19:52
-
Oli Bartsch merged patch set 9 11/15/24, 19:52
FormPagePreviewRenderer.php:64