Review main Merged

86546[TASK] Clean up site configuration functionality

Oli Bartsch CR +2 V +2 Normal +47 −89 updated 10/10/24, 13:09

Commit message

This cleans up several details in the site configuration handling,
especially in terms of caching.

* Remove SingletonInterface from `SiteConfiguration`
* Replace @internal properties with constants
* Use injected services instead of duplicated makeInstance() calls
* Replacing property based cache with runtime cache in `SiteConfiguration`

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1420

  1. Oli Bartsch uploaded patch set 1 10/10/24, 09:31

  2. Oli Bartsch uploaded patch set 2 10/10/24, 09:32

  3. core-ci voted on patch set 1 V -1 10/10/24, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67490

  4. core-ci voted on patch set 2 V -1 10/10/24, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67492

  5. Oli Bartsch uploaded patch set 3 V -1 10/10/24, 09:47

  6. core-ci voted on patch set 3 V +1 10/10/24, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67493

  7. Benjamin Franzke commented on patch set 3 CR -2 10/10/24, 11:19

    MigrateSiteSettingsConfigUpdate.php:42

    I'm against this and doubt that this works. (didn't test it) SiteSettingsFactory has many dependencies and is not supposed to run in upgrade wizard context. Sorry, I have to block this, as I see no "win" for v13 which is one week ahead.
  8. Christian Kuhn commented on patch set 3 10/10/24, 11:28

    MigrateSiteSettingsConfigUpdate.php:42 Reply

    we will change this back again and keep the method within SiteWriter.
  9. Oli Bartsch uploaded patch set 4 V +1 10/10/24, 11:52

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  10. Benjamin Franzke voted on patch set 4 CR 0 10/10/24, 11:53

  11. Oli Bartsch uploaded patch set 5 10/10/24, 11:54

  12. Oli Bartsch uploaded patch set 6 10/10/24, 11:56

  13. core-ci voted on patch set 4 V -1 10/10/24, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67504

  14. Oli Bartsch updated the commit message in patch set 7 10/10/24, 12:03

  15. core-ci voted on patch set 6 V +1 10/10/24, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67506

  16. core-ci voted on patch set 7 V +1 10/10/24, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67507

  17. Christian Kuhn voted on patch set 7 CR +1 V +1 10/10/24, 12:37

  18. Stefan Bürk voted on patch set 7 CR +1 V +1 10/10/24, 12:57

  19. Oli Bartsch voted on patch set 7 CR +2 V +2 10/10/24, 13:09

  20. Oli Bartsch merged patch set 8 10/10/24, 13:09