86546[TASK] Clean up site configuration functionality
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteDatabaseEditRowTest.php+4 −6
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+30 −48
- typo3/sysext/core/Classes/Configuration/SiteWriter.php+8 −25
- typo3/sysext/core/Classes/Site/SiteSettingsService.php+1 −3
- typo3/sysext/core/Classes/ServiceProvider.php+0 −1
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+1 −2
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Configuration/SiteWriterTest.php+0 −2
Review log 1420
-
Oli Bartsch uploaded patch set 1 10/10/24, 09:31
-
Oli Bartsch uploaded patch set 2 10/10/24, 09:32
-
core-ci voted on patch set 1 V -1 10/10/24, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67490
-
core-ci voted on patch set 2 V -1 10/10/24, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67492
-
Oli Bartsch uploaded patch set 3
V -110/10/24, 09:47 -
core-ci voted on patch set 3 V +1 10/10/24, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67493
-
Benjamin Franzke commented on patch set 3 CR -2 10/10/24, 11:19
-
Christian Kuhn commented on patch set 3 10/10/24, 11:28
MigrateSiteSettingsConfigUpdate.php:42Replywe will change this back again and keep the method within SiteWriter. -
Oli Bartsch uploaded patch set 4
V +110/10/24, 11:52Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Franzke voted on patch set 4 CR 0 10/10/24, 11:53
-
Oli Bartsch uploaded patch set 5 10/10/24, 11:54
-
Oli Bartsch uploaded patch set 6 10/10/24, 11:56
-
core-ci voted on patch set 4 V -1 10/10/24, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67504
-
Oli Bartsch updated the commit message in patch set 7 10/10/24, 12:03
-
core-ci voted on patch set 6 V +1 10/10/24, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67506
-
core-ci voted on patch set 7 V +1 10/10/24, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67507
-
Christian Kuhn voted on patch set 7 CR +1 V +1 10/10/24, 12:37
-
Stefan Bürk voted on patch set 7 CR +1 V +1 10/10/24, 12:57
-
Oli Bartsch voted on patch set 7 CR +2 V +2 10/10/24, 13:09
-
Oli Bartsch merged patch set 8 10/10/24, 13:09
MigrateSiteSettingsConfigUpdate.php:42