86547[BUGFIX] Handle `severity` configuration in `FlashMessage` finisher properly
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- Tobias Jungmann +1
-
Verified V +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- Tobias Jungmann +1
- core-ci +1 CI
Issues 3
Files 2
Review log 2736
Show 811 earlier messages
-
Andreas Kienast uploaded patch set 1 10/10/24, 10:32
-
Andreas Kienast commented on patch set 1 10/10/24, 10:37
-
core-ci voted on patch set 1 V +1 10/10/24, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67494
-
Andreas Kienast uploaded patch set 2
V +110/10/24, 10:39 -
core-ci voted on patch set 2 V +1 10/10/24, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67495
-
Tobias Jungmann commented on patch set 2 CR +1 V +1 10/10/24, 10:59
Looks good to me and works! The usage of `severity: \TYPO3\CMS\Core\Type\ContextualFeedbackSeverity::XY` in yaml configuration should definitely be documented in https://docs.typo3.org/c/typo3/cms-form/main/en-us/I/Config/proto/finishersDefinition/finishers/FlashMessage.html#prototypes.prototypeIdentifier.finishersdefinition.flashmessage.options.severity and https://docs.typo3.org/c/typo3/cms-form/main/en-us/D/FinisherOptions/Index.html#apireference-finisheroptions-flashmessagefinisher -
Benjamin Franzke commented on patch set 2 10/10/24, 11:14
FlashMessageFinisher.php:99We should we introduce constant-evaluation if we didn't had that in v11? Can't we use `ContextualFeedbackSeverity::from()` and therefore support the same syntax as in v11 – or do I get it totally wrong? I'd actually revert the `is_int` deprecation… It would only make sense to define concrete string values – I'm against exposing PHP constants in yaml configuration. -
Andreas Kienast commented on patch set 2 10/10/24, 11:18
FlashMessageFinisher.php:99ReplyI'm confused, v11 didn't have `ContextualFeedbackSeverity` at all. We could indeed use `tryFrom()` as well, at the cost of having one separate spot that allows integer values again, opposed to the rest of the Core. -
Andreas Kienast uploaded patch set 3
CR +1V +110/11/24, 08:31 -
Andreas Kienast commented on patch set 3 10/11/24, 08:38
FlashMessageFinisher.php:99ReplyDone -
core-ci voted on patch set 3 V +1 10/11/24, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67561
-
Benjamin Franzke commented on patch set 3 CR +1 10/11/24, 08:45
Reply
changed to be just the keyword, but doneFlashMessageFinisher.php:99ReplyDone -
Andreas Kienast uploaded patch set 4
CR +1V +110/11/24, 11:47 -
Andreas Kienast commented on patch set 4 CR -1 10/11/24, 11:47
FlashMessageFinisher.php:99UnresolvedNot sure anymore if this is a great idea or whether we should revert the deprecation here and allow integer values again. -
core-ci voted on patch set 4 V -1 10/11/24, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67588
-
Andreas Kienast uploaded patch set 5
CR -1V -110/11/24, 12:09 -
Andreas Kienast uploaded patch set 6 10/11/24, 12:10
-
Andreas Kienast uploaded patch set 7 10/11/24, 12:10
-
core-ci voted on patch set 7 V -1 10/11/24, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67593
-
Tobias Jungmann commented on patch set 7 10/11/24, 12:24
FlashMessageFinisher.php:102Maybe it would be more reasonable to throw an exception here instead of using the default value. If the severity is not an instance of ContextualFeedbackSeverity, the configuration is falsy and the developer should see that. -
Andreas Kienast commented on patch set 7 10/11/24, 12:43
FlashMessageFinisher.php:102ReplyThis would introduce a new breaking change. Previously, the code always fell back to the default severity. -
core-ci voted on patch set 7 V +1 10/11/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67593
-
Andreas Kienast uploaded patch set 8
V +110/11/24, 12:49 -
core-ci voted on patch set 8 V +1 10/11/24, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67597
-
Tobias Jungmann commented on patch set 8 CR +1 10/11/24, 13:22
FlashMessageFinisher.php:102ReplyAcknowledged -
Tobias Jungmann voted on patch set 8 V +1 10/11/24, 13:25
-
Oliver Hader updated the commit message in patch set 9
CR +1V +110/18/24, 13:58 -
core-ci voted on patch set 9 V +1 10/18/24, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68093
-
Tobias Jungmann commented on patch set 9 10/19/24, 06:22
FlashMessageFinisher.php:102The default option is already defined. Use `$severity = $this->defaultOptions['severity']`. -
Andreas Kienast commented on patch set 9 10/23/24, 09:07
FlashMessageFinisher.php:102ReplyAcknowledged -
Andreas Kienast uploaded patch set 10
V +110/23/24, 09:07 -
core-ci voted on patch set 10 V +1 10/23/24, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68433
-
Tobias Jungmann voted on patch set 10 CR +1 V +1 10/23/24, 10:15
-
Garvin Hicking voted on patch set 10 CR +1 V +1 10/25/24, 08:23
-
Andreas Kienast voted on patch set 10 CR +2 V +2 10/25/24, 09:23
-
Andreas Kienast merged patch set 11 10/25/24, 09:32
FlashMessageFinisher.php:101Unresolved