86548[TASK] Stateless SiteFinder
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Classes/Site/SiteFinder.php+41 −37
- typo3/sysext/core/Tests/Unit/Routing/SiteMatcherTest.php+8 −16
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteTest.php+8 −48
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php+8 −16
- typo3/sysext/redirects/Tests/Functional/EventListener/AddPlainSlugReplacementSourceTest.php+3 −3
Review log 1117
-
Christian Kuhn uploaded patch set 1 10/10/24, 10:44
-
core-ci voted on patch set 1 V -1 10/10/24, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67496
-
Christian Kuhn uploaded patch set 2
V -110/10/24, 10:59 -
core-ci voted on patch set 2 V +1 10/10/24, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67497
-
Christian Kuhn updated the commit message in patch set 3
V +110/10/24, 11:07 -
Christian Kuhn updated the commit message in patch set 4 10/10/24, 11:08
-
Christian Kuhn updated the commit message in patch set 5 10/10/24, 11:10
-
core-ci voted on patch set 3 V +1 10/10/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67498
-
core-ci voted on patch set 4 V +1 10/10/24, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67499
-
core-ci voted on patch set 5 V +1 10/10/24, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67501
-
Christian Kuhn uploaded patch set 6
V +110/10/24, 11:25 -
core-ci voted on patch set 6 V +1 10/10/24, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67502
-
Stefan Bürk voted on patch set 6 CR -1 10/10/24, 11:42
-
Stefan Bürk voted on patch set 6 CR +1 V +1 10/10/24, 11:52
-
Oli Bartsch voted on patch set 6 CR +1 V +1 10/10/24, 12:37
-
Christian Kuhn voted on patch set 6 CR +2 V +2 10/10/24, 12:44
-
Christian Kuhn merged patch set 7 10/10/24, 12:44