Review main Merged

86557[TASK] Fix spelling mistakes in a few extensions

Klaus Feiler CR +2 V +2 Easy +8 −8 updated 10/11/24, 09:04

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1519

  1. Klaus Feiler uploaded patch set 1 10/11/24, 08:19

  2. Garvin Hicking commented on patch set 1 10/11/24, 08:23

    Hey, thanks a lot for this contribution. Could you adjust the commit message title maybe to: "[DOCS] Fix spelling mistakes in several extensions" and change to "Releases: main, 12.4, 11.5" so we can backport the the fixes? :)
  3. Georg Ringer commented on patch set 1 10/11/24, 08:24

    Reply

    I suppose 12.4 is enough, 11.5 is kind of EOL in 1 week
  4. core-ci voted on patch set 1 V +1 10/11/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67557

  5. Georg Ringer commented on patch set 1 10/11/24, 08:25

    it is not only DOCS, so I suggest TASK is fine then
  6. Jennifer Kraftl uploaded patch set 2 V +1 10/11/24, 08:29

  7. core-ci voted on patch set 2 V +1 10/11/24, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67559

  8. Benjamin Franzke commented on patch set 2 10/11/24, 08:41

    Thanks for your patch! Please start summary lines with a capital letter, see examples on https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html#summary-line-first-line
  9. Georg Ringer updated the commit message in patch set 3 V +1 10/11/24, 08:46

  10. Benjamin Franzke commented on patch set 3 CR +1 V +1 10/11/24, 08:47

    Reply

    Done
  11. Georg Ringer voted on patch set 3 CR +1 V +1 10/11/24, 08:48

  12. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 10/11/24, 08:48

  13. Garvin Hicking voted on patch set 4 CR +1 V +1 10/11/24, 08:48

  14. core-ci voted on patch set 3 V +1 10/11/24, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67563

  15. Georg Ringer voted on patch set 4 CR +1 V +1 10/11/24, 08:59

  16. Oliver Hader voted on patch set 4 CR +1 10/11/24, 08:59

  17. Garvin Hicking voted on patch set 4 CR +2 V +2 10/11/24, 09:00

  18. core-ci voted on patch set 4 V +1 10/11/24, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67566

  19. Garvin Hicking merged patch set 5 10/11/24, 09:04