86557[TASK] Fix spelling mistakes in a few extensions
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Oliver Hader +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/dashboard/Documentation/Editor/Index.rst+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMap.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/SaveToDatabaseFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+1 −1
- typo3/sysext/recycler/Documentation/Editor/Index.rst+1 −1
Review log 1519
-
Klaus Feiler uploaded patch set 1 10/11/24, 08:19
-
Garvin Hicking commented on patch set 1 10/11/24, 08:23
Hey, thanks a lot for this contribution. Could you adjust the commit message title maybe to: "[DOCS] Fix spelling mistakes in several extensions" and change to "Releases: main, 12.4, 11.5" so we can backport the the fixes? :) -
Georg Ringer commented on patch set 1 10/11/24, 08:24
Reply
I suppose 12.4 is enough, 11.5 is kind of EOL in 1 week -
core-ci voted on patch set 1 V +1 10/11/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67557
-
Georg Ringer commented on patch set 1 10/11/24, 08:25
it is not only DOCS, so I suggest TASK is fine then -
Jennifer Kraftl uploaded patch set 2
V +110/11/24, 08:29 -
core-ci voted on patch set 2 V +1 10/11/24, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67559
-
Benjamin Franzke commented on patch set 2 10/11/24, 08:41
Thanks for your patch! Please start summary lines with a capital letter, see examples on https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html#summary-line-first-line -
Georg Ringer updated the commit message in patch set 3
V +110/11/24, 08:46 -
Benjamin Franzke commented on patch set 3 CR +1 V +1 10/11/24, 08:47
Reply
Done -
Georg Ringer voted on patch set 3 CR +1 V +1 10/11/24, 08:48
-
Garvin Hicking updated the commit message in patch set 4
CR +1V +110/11/24, 08:48 -
Garvin Hicking voted on patch set 4 CR +1 V +1 10/11/24, 08:48
-
core-ci voted on patch set 3 V +1 10/11/24, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67563
-
Georg Ringer voted on patch set 4 CR +1 V +1 10/11/24, 08:59
-
Oliver Hader voted on patch set 4 CR +1 10/11/24, 08:59
-
Garvin Hicking voted on patch set 4 CR +2 V +2 10/11/24, 09:00
-
core-ci voted on patch set 4 V +1 10/11/24, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67566
-
Garvin Hicking merged patch set 5 10/11/24, 09:04