Review main Merged

86558[TASK] Add links to documentations in the backend

Frank Nägler CR +2 V +2 Normal +96 −4 updated 10/11/24, 13:58

Commit message

Add links to documentation for easier access and improved
user experience.

This integrates the new permalink feature, see:
https://github.com/TYPO3-Documentation/render-guides/pull/781

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2332

Show 57 earlier messages
  1. Frank Nägler uploaded patch set 1 10/11/24, 08:58

  2. Andreas Kienast commented on patch set 1 10/11/24, 09:10

    DocumentationViewHelper.php:66

    Please add `rel="noreferrer"` as well.

    Overview.html:2

    4 spaces
  3. core-ci voted on patch set 1 V -1 10/11/24, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67574

  4. Frank Nägler uploaded patch set 2 V -1 10/11/24, 09:31

  5. Frank Nägler commented on patch set 2 10/11/24, 09:32

    DocumentationViewHelper.php:66 Reply

    Acknowledged

    Overview.html:2 Reply

    Acknowledged
  6. core-ci voted on patch set 2 V -1 10/11/24, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67580

  7. Benjamin Franzke uploaded patch set 3 V -1 10/11/24, 09:42

  1. Andreas Kienast updated the commit message in patch set 4 CR +1 V +1 10/11/24, 09:46

  2. Andreas Kienast voted on patch set 4 CR +1 V +1 10/11/24, 09:48

  3. core-ci voted on patch set 3 V +1 10/11/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67581

  4. core-ci voted on patch set 4 V +1 10/11/24, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67582

  5. Frank Nägler uploaded patch set 5 CR +1 V +1 10/11/24, 10:27

  6. Benjamin Franzke voted on patch set 5 CR +1 V +1 10/11/24, 10:28

  7. Garvin Hicking commented on patch set 5 CR -1 10/11/24, 10:31

    hang on, few typos, on it
  8. core-ci voted on patch set 5 V +1 10/11/24, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67584

  9. Garvin Hicking commented on patch set 6 CR +1 V +1 10/11/24, 10:35

    Published edit on patch set 5.
  10. Garvin Hicking commented on patch set 6 CR +1 V +1 10/11/24, 10:36

    We should "handle this with care". There might be edge cases of this permalink feature, especially with deeper links or links to "confvals". Most of the issues should be fixable then in the redirect handling or the objects.inv.json generation outside TYPO3 core. The minimal handling of the VH in this patch for now seems good to me!
  11. core-ci voted on patch set 6 V +1 10/11/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67585

  12. Frank Nägler uploaded patch set 7 CR +1 V +1 10/11/24, 11:03

  13. Frank Nägler commented on patch set 6 CR -1 10/11/24, 11:07

    blocked, until fix on docs-server regarding unknown @verison parameter is fixed.
  14. core-ci voted on patch set 7 V +1 10/11/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67586

  15. Frank Nägler commented on patch set 7 CR -1 10/11/24, 11:16

    blocked, until fix on docs-server regarding unknown @verison parameter is fixed.
  16. Frank Nägler uploaded patch set 8 CR -1 V +1 10/11/24, 11:46

  17. Frank Nägler commented on patch set 8 CR -1 10/11/24, 11:46

    blocked, until fix on docs-server regarding unknown @verison parameter is fixed.
  18. core-ci voted on patch set 8 V +1 10/11/24, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67587

  19. Frank Nägler voted on patch set 8 CR 0 10/11/24, 13:28

  20. Andreas Kienast uploaded patch set 9 V +1 10/11/24, 13:33

  21. Andreas Kienast voted on patch set 9 CR +1 V +1 10/11/24, 13:33

  22. core-ci voted on patch set 9 V +1 10/11/24, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67599

  23. Benjamin Franzke voted on patch set 9 CR +1 V +1 10/11/24, 13:46

  24. Andreas Kienast voted on patch set 9 CR +2 V +2 10/11/24, 13:48

  25. Andreas Kienast merged patch set 10 10/11/24, 13:58