Review main Merged

86559[TASK] Simplify TypoScript -> Included TypoScript view

Christian Kuhn CR +2 V +2 Hard +3 −255 updated 10/12/24, 09:05

Commit message

When we redesigned the TypoScript main module in v12, we
thought it is a good idea to make the "Included TypoScript"
condition aware, similar to "Active TypoScript": @import
statements within condition bodies were reflected in the
rendered include tree and condition verdicts could be
toggled, simulating their effect on the resulting include
tree.

This however broke in v12 quickly after first
implementation patches, leaving only a "matched" or
"not matched" badge per listed condition in the tree,
without further useful impact.

Note conditions are rendered as "title" in the tree since
v13 #105276, which helps the overal usefulness of the
"Include tree" a lot.

The patch removes the entire condition list and verdict
selection panel in "Included TypoScript" since it does
not contain good information nor functionality in this
view.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 7

Review log 1418

  1. Christian Kuhn uploaded patch set 1 10/11/24, 11:48

  2. core-ci voted on patch set 1 V +1 10/11/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67589

  3. Christian Kuhn updated the commit message in patch set 2 V +1 10/11/24, 12:09

  4. Christian Kuhn updated the commit message in patch set 3 10/11/24, 12:10

  5. core-ci voted on patch set 2 V +1 10/11/24, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67590

  6. core-ci voted on patch set 3 V +1 10/11/24, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67594

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 10/11/24, 12:46

  8. Stefan Froemken voted on patch set 3 CR +1 V +1 10/11/24, 14:44

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 10/11/24, 14:47

  10. Christian Kuhn voted on patch set 3 V 0 CR -1 10/11/24, 14:50

  11. Christian Kuhn commented on patch set 3 10/11/24, 14:52

    locallang_analyzer.xlf:31

    at least this label is used in 'active typoscript'
  12. Christian Kuhn uploaded patch set 4 CR +1 V +1 10/11/24, 14:57

  13. Christian Kuhn commented on patch set 4 10/11/24, 14:57

    locallang_analyzer.xlf:31 Reply

    Done
  14. core-ci voted on patch set 4 V +1 10/11/24, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67607

  15. Stefan Bürk voted on patch set 4 CR +1 V +1 10/11/24, 16:34

  16. Anja Leichsenring voted on patch set 4 CR +1 V +1 10/12/24, 08:12

  17. Christian Kuhn voted on patch set 4 CR +2 V +2 10/12/24, 09:05

  18. Christian Kuhn merged patch set 5 10/12/24, 09:05