86561[TASK] Replace TYPO3 `EnumType` with doctrine/dbal type
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php+5 −5
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/CustomDoctrineTypesColumnDefinitionTrait.php+4 −1
- typo3/sysext/core/Classes/Database/Schema/Types/EnumType.phpdeleted+0 −61
- typo3/sysext/core/Classes/Database/ConnectionPool.php+0 −2
- typo3/sysext/core/Documentation/Changelog/13.4/Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst4new+53 −0
- typo3/sysext/core/Migrations/Code/ClassAliasMap.php2new+20 −0
- typo3/sysext/core/Migrations/Code/LegacyClassesForIde.phpnew+39 −0
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+1 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/MySQLSchemaManagerTest.php+3 −8
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/PostgreSQLSchemaManagerTest.php+3 −8
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/SQLiteSchemaManagerTest.php+3 −8
- typo3/sysext/core/Tests/Unit/Database/Schema/Types/EnumTypeTest.phpdeleted+0 −56
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/install/composer.json+1 −1
- typo3/sysext/redirects/composer.json+1 −1
- composer.json+1 −1
- composer.lock+9 −9
Review log 2031
Show 36 earlier messages
-
Stefan Bürk uploaded patch set 1 10/11/24, 16:27
-
core-ci voted on patch set 1 V -1 10/11/24, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67609
-
Stefan Bürk uploaded patch set 2
V -110/11/24, 17:20 -
core-ci voted on patch set 2 V -1 10/11/24, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67612
-
Stefan Bürk uploaded patch set 3
V -110/11/24, 17:49 -
core-ci voted on patch set 3 V +1 10/11/24, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67614
-
Stefan Bürk uploaded patch set 4
V +110/11/24, 18:39 -
Stefan Bürk updated the commit message in patch set 5 10/11/24, 18:42
-
core-ci voted on patch set 5 V +1 10/11/24, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67616
-
core-ci voted on patch set 5 V -1 10/11/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67617
-
Stefan Bürk updated the commit message in patch set 6
V -110/11/24, 19:15 -
core-ci voted on patch set 6 V +1 10/11/24, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67618
-
Stefan Bürk rebased onto patch set 7
V +110/11/24, 19:34 -
core-ci voted on patch set 7 V +1 10/11/24, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67620
-
core-ci commented on patch set 7 10/11/24, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67621
-
Nikita Hovratov voted on patch set 7 CR +1 10/11/24, 22:30
-
Stefan Bürk updated the commit message in patch set 8
CR +1V +110/12/24, 08:17 -
core-ci voted on patch set 8 V +1 10/12/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67640
-
Christian Kuhn commented on patch set 8 CR -1 10/12/24, 10:42
i'll apply some wording changes. -
Christian Kuhn uploaded patch set 9
CR -1V +110/12/24, 10:58 -
Christian Kuhn voted on patch set 9 CR +1 V +1 10/12/24, 10:59
-
core-ci voted on patch set 9 V +1 10/12/24, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67643
-
Garvin Hicking commented on patch set 9 CR +1 V +1 10/12/24, 11:57
minor spelling, can also apply in a rst cleanup later.Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:14did provide -> providedDeprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:25space before dot -
Garvin Hicking commented on patch set 10
CR +1V +110/12/24, 12:17Published edit on patch set 9. -
Garvin Hicking commented on patch set 10 CR +1 V +1 10/12/24, 12:17
Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:14ReplyDoneDeprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:25ReplyDone -
core-ci voted on patch set 10 V +1 10/12/24, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67647
-
Christian Kuhn voted on patch set 10 CR +1 V +1 10/12/24, 13:05
-
Stefan Bürk voted on patch set 10 CR +2 V +2 10/12/24, 13:05
-
Stefan Bürk merged patch set 11 10/12/24, 13:05
-
Benjamin Franzke commented on patch set 11 10/12/24, 14:38
ClassAliasMap.php:1This ClassAliasMap has not been registered in /composer.json and /typo3/sysext/core/composer.json -
Stefan Bürk commented on patch set 11 10/13/24, 15:26
ClassAliasMap.php:1ReplyThanks, missed that. Correct(ed) with https://review.typo3.org/c/Packages/TYPO3.CMS/+/86575