Review main Merged

86562[TASK] Ensure corect value preparation for test assertion

Stefan Bürk CR +2 V +2 Easy +16 −5 updated 10/11/24, 20:01

Commit message

This change prepares data converting it forth and back on
the retrieved value and the expectation value. Note, that
this is required as different databases persists json data
differently into the columns, and return the values slightly
reformatted.

For example, removing spaces between colons and double-quotes:

* put in:               {"key": "value"}
* saved and returned as {"key":"value"}

Avoiding "concrete" expectations for each database vendor
and version, two way convertion is used on expected and
retrieved data. The test goal is to match that the json
data could be saved at all and is not changed by this change.

This test has been recently added with #105208 but did not
failed on execution on the change directly.

[1] https://git.typo3.org/typo3/CI/cms/-/jobs/3856803

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 10/11/24, 19:34

  2. core-ci voted on patch set 1 V +1 10/11/24, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67619

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 10/11/24, 19:44

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 10/11/24, 19:57

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 10/11/24, 20:01

  6. Stefan Bürk merged patch set 2 10/11/24, 20:01