Review main Merged

86563[BUGFIX] Add missing debug information

Oli Bartsch CR +2 V +2 Normal +43 −36 updated 10/14/24, 09:36

Commit message

Debug information (e.g. field names) are now
displayed again in the backend user (group)
compare view - if debug output is enabled for
the user.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2433

Show 58 earlier messages
  1. Oli Bartsch uploaded patch set 1 10/11/24, 21:38

  2. Oli Bartsch uploaded patch set 2 10/11/24, 21:43

  3. core-ci voted on patch set 1 V +1 10/11/24, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67623

  4. core-ci voted on patch set 2 V +1 10/11/24, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67624

  5. Stefan Bürk uploaded patch set 3 V +1 10/12/24, 12:11

  6. Stefan Bürk voted on patch set 3 CR +1 V +1 10/12/24, 12:12

  7. core-ci voted on patch set 3 V +1 10/12/24, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67646

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 10/13/24, 06:07

  1. Anja Leichsenring commented on patch set 3 CR 0 V 0 10/13/24, 06:25

    trying the backport
  2. Anja Leichsenring commented on patch set 3 10/13/24, 06:26

    Compare.html:47

    uid of user record missing here.
  3. Anja Leichsenring commented on patch set 3 10/13/24, 06:41

    Compare.html:223

    duplicate
  4. Anja Leichsenring uploaded patch set 4 CR +1 V +1 10/13/24, 06:44

  5. Anja Leichsenring commented on patch set 4 CR +1 V +1 10/13/24, 06:44

    Compare.html:47 Reply

    Done

    Compare.html:223 Reply

    Done
  6. core-ci voted on patch set 4 V -1 10/13/24, 06:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67677

  7. Anja Leichsenring uploaded patch set 5 CR +1 V +1 10/13/24, 07:06

  8. core-ci voted on patch set 5 V +1 10/13/24, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67680

  9. Anja Leichsenring voted on patch set 5 CR +1 V +1 10/13/24, 07:14

  10. Anja Leichsenring commented on patch set 5 10/13/24, 07:19

    backport is a mess due to changed markup from #104635. Maybe we should just skip it?
  11. Oli Bartsch uploaded patch set 6 CR +1 V +1 10/13/24, 14:18

  12. core-ci voted on patch set 6 V +1 10/13/24, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67700

  13. Oli Bartsch uploaded patch set 7 V +1 10/13/24, 14:30

  14. Oli Bartsch updated the commit message in patch set 8 10/13/24, 14:35

  15. Oli Bartsch commented on patch set 8 10/13/24, 14:35

    Reply

    12.4 does not have the "showUid" functionality. Would therefore skip the backport.
  16. core-ci voted on patch set 7 V -1 10/13/24, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67701

  17. core-ci voted on patch set 8 V -1 10/13/24, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67702

  18. Oli Bartsch uploaded patch set 9 V -1 10/13/24, 17:35

  19. Anja Leichsenring commented on patch set 8 10/13/24, 17:35

    showUid is available, would onlyzneed te be supplied. But the markup changes spoil the fun. As for my additional span for the user uid in table header - there was a reason. Now the acceptance test fails again.
  20. core-ci voted on patch set 9 V +1 10/13/24, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67716

  21. Oli Bartsch commented on patch set 9 10/13/24, 17:43

    Reply

    Where is `showUid` defined, I'm can't spot it in v12? The addition led to empty span tags in case `showUid` is false. I tend to adjust the test instead of rendering such markup.
  22. Stefan Bürk voted on patch set 9 CR +1 V +1 10/14/24, 07:45

  23. Anja Leichsenring voted on patch set 9 CR +1 V +1 10/14/24, 09:22

  24. Oli Bartsch commented on patch set 9 CR +2 V +2 10/14/24, 09:36

    Reply

    Done
  25. Oli Bartsch merged patch set 10 10/14/24, 09:36