86563[BUGFIX] Add missing debug information
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/beuser/Classes/Service/UserInformationService.php+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html+11 −10
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html4+16 −12
- typo3/sysext/beuser/Resources/Private/Templates/BackendUserGroup/Compare.html+13 −11
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/CompareUserCest.php+2 −2
Review log 2433
Show 58 earlier messages
-
Oli Bartsch uploaded patch set 1 10/11/24, 21:38
-
Oli Bartsch uploaded patch set 2 10/11/24, 21:43
-
core-ci voted on patch set 1 V +1 10/11/24, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67623
-
core-ci voted on patch set 2 V +1 10/11/24, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67624
-
Stefan Bürk uploaded patch set 3
V +110/12/24, 12:11 -
Stefan Bürk voted on patch set 3 CR +1 V +1 10/12/24, 12:12
-
core-ci voted on patch set 3 V +1 10/12/24, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67646
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 10/13/24, 06:07
-
Anja Leichsenring commented on patch set 3 CR 0 V 0 10/13/24, 06:25
trying the backport -
Anja Leichsenring commented on patch set 3 10/13/24, 06:26
Compare.html:47uid of user record missing here. -
Anja Leichsenring commented on patch set 3 10/13/24, 06:41
Compare.html:223duplicate -
Anja Leichsenring uploaded patch set 4
CR +1V +110/13/24, 06:44 -
Anja Leichsenring commented on patch set 4 CR +1 V +1 10/13/24, 06:44
Compare.html:47ReplyDoneCompare.html:223ReplyDone -
core-ci voted on patch set 4 V -1 10/13/24, 06:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67677
-
Anja Leichsenring uploaded patch set 5
CR +1V +110/13/24, 07:06 -
core-ci voted on patch set 5 V +1 10/13/24, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67680
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 10/13/24, 07:14
-
Anja Leichsenring commented on patch set 5 10/13/24, 07:19
backport is a mess due to changed markup from #104635. Maybe we should just skip it? -
Oli Bartsch uploaded patch set 6
CR +1V +110/13/24, 14:18 -
core-ci voted on patch set 6 V +1 10/13/24, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67700
-
Oli Bartsch uploaded patch set 7
V +110/13/24, 14:30 -
Oli Bartsch updated the commit message in patch set 8 10/13/24, 14:35
-
Oli Bartsch commented on patch set 8 10/13/24, 14:35
Reply
12.4 does not have the "showUid" functionality. Would therefore skip the backport. -
core-ci voted on patch set 7 V -1 10/13/24, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67701
-
core-ci voted on patch set 8 V -1 10/13/24, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67702
-
Oli Bartsch uploaded patch set 9
V -110/13/24, 17:35 -
Anja Leichsenring commented on patch set 8 10/13/24, 17:35
showUid is available, would onlyzneed te be supplied. But the markup changes spoil the fun. As for my additional span for the user uid in table header - there was a reason. Now the acceptance test fails again. -
core-ci voted on patch set 9 V +1 10/13/24, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67716
-
Oli Bartsch commented on patch set 9 10/13/24, 17:43
Reply
Where is `showUid` defined, I'm can't spot it in v12? The addition led to empty span tags in case `showUid` is false. I tend to adjust the test instead of rendering such markup. -
Stefan Bürk voted on patch set 9 CR +1 V +1 10/14/24, 07:45
-
Anja Leichsenring voted on patch set 9 CR +1 V +1 10/14/24, 09:22
-
Oli Bartsch commented on patch set 9 CR +2 V +2 10/14/24, 09:36
Reply
Done -
Oli Bartsch merged patch set 10 10/14/24, 09:36