Review main Merged

86569[TASK] Streamline SystemEnvironmentBuilder

Stefan Bürk CR +2 V +2 Easy +27 −20 updated 10/14/24, 13:39

Commit message

Exchange `self::method()` calls with static to allow
the typo3/testing-framework to steer system building
more dynamically by extending and overriding methods
when needed.

[1] https://github.com/TYPO3/testing-framework/issues/577

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 4

Files 1

Review log 914

  1. Stefan Bürk uploaded patch set 1 10/12/24, 17:32

  2. core-ci voted on patch set 1 V -1 10/12/24, 17:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67657

  3. Stefan Bürk uploaded patch set 2 V -1 10/12/24, 18:11

  4. core-ci voted on patch set 2 V -1 10/12/24, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67659

  5. Stefan Bürk uploaded patch set 3 V -1 10/12/24, 18:27

  6. core-ci voted on patch set 3 V +1 10/12/24, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67663

  7. Stefan Bürk updated the commit message in patch set 4 V +1 10/12/24, 18:41

  8. core-ci voted on patch set 4 V +1 10/12/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67664

  9. Stefan Bürk updated the commit message in patch set 5 V +1 10/13/24, 15:51

  10. core-ci voted on patch set 5 V +1 10/13/24, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67709

  11. Garvin Hicking voted on patch set 5 CR +1 V +1 10/13/24, 18:18

  12. Christian Kuhn commented on patch set 5 CR +1 V +1 10/14/24, 13:38

    Note this is a tribute to the current TF situation which we can't change at this point in time.
  13. Stefan Bürk voted on patch set 5 CR +2 V +2 10/14/24, 13:39

  14. Stefan Bürk merged patch set 6 10/14/24, 13:39