Review main Merged

86571[TASK] Merge AdminPanelDataPersister into AdminPanelRenderer

Christian Kuhn CR +2 V +2 Normal +4 −65 updated 10/13/24, 11:06

Commit message

The admin panel suffers from a few issues that are
complex to track down and to get right due to the
complex interplay of the various involved admin
panel middlewares.

As a first patch in this area we simplify the
construct a bit.

The admin panel comes with four middlewares:
* The pretty early AdminPanelInitiator
* An intermediate SqlLogging (not of relevance
  with this patch)
* AdminPanelRenderer that renders the admin
  panel and merges it into response body using
  MainController
* AdminPanelDataPersister that sets gathered
  data needed for AdminPanelRenderer into
  MainController

AdminPanelDataPersister is located directly after
AdminPanelRenderer in the middleware chain. Both
middlewares do things *after* calling
$handler->handle($request), so the code executed
in AdminPanelDataPersister is run directly *before*
the code in AdminPanelRenderer.

The patch merges the code from AdminPanelDataPersister
into AdminPanelRenderer directly before the existing
handling of AdminPanelRenderer which obsoletes
AdminPanelDataPersister.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 710

  1. Christian Kuhn uploaded patch set 1 10/13/24, 10:12

  2. core-ci voted on patch set 1 V +1 10/13/24, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67682

  3. Christian Kuhn updated the commit message in patch set 2 V +1 10/13/24, 10:25

  4. core-ci voted on patch set 2 V +1 10/13/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67683

  5. Christian Kuhn updated the commit message in patch set 3 V +1 10/13/24, 10:44

  6. Garvin Hicking voted on patch set 3 CR +1 V +1 10/13/24, 10:49

  7. core-ci voted on patch set 3 V +1 10/13/24, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67684

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 10/13/24, 10:52

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 10/13/24, 11:06

  10. Christian Kuhn merged patch set 4 10/13/24, 11:06