Review main Merged

86574[TASK] Align custom `SetType` doctrine type implementation

Stefan Bürk CR +2 V +2 Easy +14 −19 updated 10/14/24, 04:33

Commit message

Doctrine DBAL recently added and released a new version
including a `ENUM` type [1], colliding with the custom
TYPO3 EnumType implementation, `ext_tables.sql` parsing
and handling during the database compare.

That had to been mitigated by changing TYPO3, and as a
Doctrine DBAL Type was available which mitigated not
solved issues within the TYPO3 implementation, it has
been removed in favour of the doctrine type with #105279.

This change streamlines the custom type implementation
`SetType`, which works similar to the removed `EnumType`
implementation to align with the way how Doctrine DBAL
implemented the `EnumType`. In the hope that a `SetType`
implementation would follow the same way the changes
should help to avoid breaking in case Doctrine DBAL
adds a `SetType` too - but not guaranteed.

Note that TYPO3 will try to contribute the SetType to
follow that pattern after v13 LTS.

[1] https://github.com/doctrine/dbal/releases/tag/4.2.0

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 56

  1. Stefan Bürk uploaded patch set 1 10/13/24, 15:05

  2. core-ci voted on patch set 1 V +1 10/13/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67703

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 10/13/24, 16:27

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 10/13/24, 17:45

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 10/14/24, 04:33

  6. Stefan Bürk merged patch set 2 10/14/24, 04:33