86576[TASK] Better handle PSR-14 event output in EXT:adminpanel
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 11
- Build/Sources/Sass/adminpanel.scss+5 −3
- typo3/sysext/adminpanel/Classes/Modules/Debug/Events.php+8 −25
- typo3/sysext/adminpanel/Classes/Service/EventDispatcher.php+7 −5
- typo3/sysext/adminpanel/Classes/Utility/HtmlDumper.phpdeleted+0 −61
- typo3/sysext/adminpanel/Configuration/ContentSecurityPolicies.php2+1 −3
- typo3/sysext/adminpanel/Resources/Private/Language/locallang_debug.xlf+6 −0
- typo3/sysext/adminpanel/Resources/Private/Templates/Modules/Debug/Events.html+24 −1
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+2 −2
- typo3/sysext/adminpanel/composer.json+0 −1
- composer.json+0 −1
- composer.lock+84 −84
Review log 1217
-
Christian Kuhn uploaded patch set 1 10/13/24, 15:41
-
Christian Kuhn uploaded patch set 2 10/13/24, 15:48
-
core-ci voted on patch set 1 V -1 10/13/24, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67707
-
core-ci voted on patch set 2 V +1 10/13/24, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67708
-
Christian Kuhn commented on patch set 2 10/13/24, 16:17
-
Christian Kuhn uploaded patch set 3 10/13/24, 16:30
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
Christian Kuhn commented on patch set 3 10/13/24, 16:31
rebased. still needs a manual test with enabled FE CSP. -
core-ci voted on patch set 3 V +1 10/13/24, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67712
-
Christian Kuhn uploaded patch set 4
V +110/14/24, 09:43 -
Christian Kuhn commented on patch set 4 10/14/24, 09:49
Reply
DoneContentSecurityPolicies.php:15ReplyWe still need style 'unsafe-inline' since QueryInformation.html contains style="..." attributes for the 'progress bar'. But we don't need StyleSrcElem since there is no <style tag in admin panel. -
core-ci voted on patch set 4 V +1 10/14/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67748
-
Garvin Hicking updated the commit message in patch set 5
V +110/14/24, 12:13 -
Garvin Hicking voted on patch set 5 CR +1 V +1 10/14/24, 12:13
-
core-ci voted on patch set 5 V +1 10/14/24, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67751
-
Stefan Bürk voted on patch set 5 CR +1 V +1 10/14/24, 13:36
-
Christian Kuhn voted on patch set 5 CR +2 V +2 10/14/24, 13:36
-
Christian Kuhn merged patch set 6 10/14/24, 13:36
ContentSecurityPolicies.php:15