Review main Abandoned

86587[BUGFIX] Set viewport relative max-height for settings editor navigation

Benjamin Franzke CR 0 V 0 Easy +17 −5 updated 04/13/25, 12:21

Commit message

Ensure that the settings editor navigation does not exceed
the viewport boundaries and is scrollable by itself if there
is not enough vertical space to be shown as a whole.

Also make sure that the scroll position inside the navigation
is automatically updated based on the scroll state of the settings
list.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 68

  1. Benjamin Franzke uploaded patch set 1 10/14/24, 14:46

  2. core-ci voted on patch set 1 V +1 10/14/24, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67769

  3. Benjamin Franzke uploaded patch set 2 V +1 10/14/24, 15:06

  4. core-ci voted on patch set 2 V +1 10/14/24, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67770

  5. Benjamin Franzke commented on patch set 2 CR -1 10/14/24, 19:38

    will work on some details
  6. Lina Wolf commented on patch set 2 12/13/24, 11:23

    Watching...
  7. Benjamin Franzke marked it work in progress 12/19/24, 09:27

  8. Benjamin Franzke abandoned the change 04/13/25, 12:21