Review main Merged

86588[BUGFIX] Avoid list_type deprecation message in TCA ext_tables.php check

Torben Hansen CR +2 V +2 Easy +4 −1 updated 10/14/24, 19:10

Commit message

When TCA ext_tables.php check is executed in install tool, there is
no extension configuration. This leads to
`ExtensionManagementUtility::addPlugin()` being called with
`list_type` as type, because `ExtensionUtility::registerPlugin()`
falls back to `list_type`, if no plugin type for an extension
can be evaluated via `EXTCONF`.

This change prevents the deprecation being logged, by checking
the instance of the static package manager in
`ExtensionManagementUtility`. In case it is an instance of
`FailsafePackageManager`, the call to
`ExtensionManagementUtility::addPlugin()` is invoked via
install tool.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Kevin Appelt +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Kevin Appelt +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Torben Hansen uploaded patch set 1 10/14/24, 16:01

  2. core-ci voted on patch set 1 V +1 10/14/24, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67772

  3. Torben Hansen uploaded patch set 2 V +1 10/14/24, 16:11

  4. Torben Hansen uploaded patch set 3 10/14/24, 16:12

  5. core-ci voted on patch set 2 V +1 10/14/24, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67773

  6. core-ci voted on patch set 3 V +1 10/14/24, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67774

  7. Nikita Hovratov voted on patch set 3 CR +1 V +1 10/14/24, 16:56

  8. Oli Bartsch commented on patch set 3 10/14/24, 18:50

    How can this be reproduced?
  9. Kevin Appelt commented on patch set 3 CR +1 V +1 10/14/24, 18:51

    Looks good to me and the previously falsely written deprecation log entry is not written anymore.
  10. Kevin Appelt commented on patch set 3 10/14/24, 18:54

    Reply

    Basically: execute the "Check TCA" in install tool and the deprecation log entry will be written. There is a thread in slack for this: https://typo3.slack.com/archives/C03AM9R17/p1728912695513859
  11. Oli Bartsch commented on patch set 3 CR +1 V +1 10/14/24, 19:06

    Reply

    Acknowledged
  12. Oli Bartsch voted on patch set 3 CR +2 V +2 10/14/24, 19:10

  13. Oli Bartsch merged patch set 4 10/14/24, 19:10