Review main Merged

86589[TASK] Adjust DocumentationViewHelper for strict linking functionality

Oli Bartsch CR +2 V +2 Normal +72 −6 updated 10/15/24, 13:28

Commit message

This adjusts the DocumentationViewHelper class
comment to properly document which links will
be generated. This is now also covered by
corresponding tests.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 2026

Show 1 earlier messages
  1. Oli Bartsch uploaded patch set 1 10/14/24, 19:49

  1. Oli Bartsch updated the commit message in patch set 2 10/14/24, 19:53

  2. core-ci voted on patch set 1 V -1 10/14/24, 19:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67777

  3. core-ci voted on patch set 2 V -1 10/14/24, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67778

  4. Garvin Hicking commented on patch set 2 10/15/24, 06:00

    Thanks for catching this mismatch. I am unsure though if we want to allow the viewhelper to do specific version links; the phpdoc comment was added before automatig version insertion was introduced to it. So maybe we better cleanup the phpdoc comment that versions must not be specified? My reasoning is that people might accidentally insert specific "13.4" version links and then forget to adapt that when 13.4 becomes main. I think internal links should always be bound to their release versions, but not 100% sure there isn't a case where a manual version could be helpful. wdyt?
  5. Garvin Hicking commented on patch set 2 10/15/24, 06:00

    Reply

    (unresolved)
  6. Oli Bartsch uploaded patch set 3 V -1 10/15/24, 06:51

  7. core-ci voted on patch set 3 V +1 10/15/24, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67795

  8. Benjamin Franzke commented on patch set 3 10/15/24, 07:54

    We excluded it until we have a real usecase, do you have one?

    DocumentationViewHelper.php:60

    Please add the version as an additional new argument.
  9. Benjamin Franzke voted on patch set 3 CR -1 10/15/24, 07:54

  10. Oli Bartsch uploaded patch set 4 CR -1 V +1 10/15/24, 08:08

  11. Benjamin Franzke commented on patch set 4 CR +1 V +1 10/15/24, 08:09

    DocumentationViewHelper.php:60 Reply

    Done
  12. Benjamin Franzke voted on patch set 4 CR 0 V 0 10/15/24, 08:09

  13. Benjamin Franzke commented on patch set 4 10/15/24, 08:10

    DocumentationViewHelper.php:62

    Why did you remove this line? it is thrown. (I mean, I don't care for IDEs, but Frank did :D)
  14. core-ci voted on patch set 4 V +1 10/15/24, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67810

  15. Oli Bartsch uploaded patch set 5 V +1 10/15/24, 09:03

  16. Oli Bartsch commented on patch set 5 10/15/24, 09:03

    DocumentationViewHelper.php:62 Reply

    Done
  17. Oli Bartsch commented on patch set 5 10/15/24, 09:03

    Reply

    Done
  18. core-ci voted on patch set 5 V +1 10/15/24, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67821

  19. Garvin Hicking commented on patch set 5 CR +1 V +1 10/15/24, 09:22

    Thanks!
  20. Benjamin Franzke voted on patch set 5 CR +1 V +1 10/15/24, 09:27

  21. Garvin Hicking updated the commit message in patch set 6 CR +1 V +1 10/15/24, 10:22

  22. Garvin Hicking commented on patch set 6 CR +1 V +1 10/15/24, 10:22

    (Typo in commit title and tried to slightly rephrase)
  23. core-ci voted on patch set 6 V +1 10/15/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67831

  24. Oli Bartsch voted on patch set 6 CR +2 V +2 10/15/24, 13:28

  25. Oli Bartsch merged patch set 7 10/15/24, 13:28