Review main Abandoned

86590[BUGFIX] Preserve search term in filelist module

Sébastien Delcroix CR 0 V 0 Easy +10 −1 updated 03/03/25, 16:09

Commit message

In `filelist` module, some actions on files rely on query parameters of
the top `list_frame` to build their return URL.
One of these query parameters is the `searchTerm` which has to be
present in the return URL in order to preserve the search results after
the action is ended.

However, the search term was added to the query parameters only from the
second search form submission, and its value didn't contain the current
search term but the previous one, and so on.

This patch sets the search term in query part of the current URL when
the `filelist` module is loaded if a search has been submitted.

The following actions were identified having wrong return URL and are
now fixed :
  * deletion of a single file (in "list view" mode)
  * edit metadata (primary action) of a single file (in both view modes)

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 69

  1. Sébastien Delcroix uploaded patch set 1 10/14/24, 22:53

  2. core-ci voted on patch set 1 V +1 10/14/24, 22:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67780

  3. Oliver Hader updated the commit message in patch set 2 V +1 10/18/24, 13:55

  4. core-ci voted on patch set 2 V +1 10/18/24, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68090

  5. Oliver Hader rebased onto patch set 3 V +1 01/08/25, 16:45

  6. core-ci voted on patch set 3 V +1 01/08/25, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72107

  7. Andreas Kienast commented on patch set 3 02/20/25, 11:55

    Unresolved

  8. Andreas Kienast abandoned the change 03/02/25, 10:36

    Thank you again Sébastien for your patch. The alternative patch has been merged meanwhile, therefore I'll close your PR. I hope this is fine for you.
  9. Sébastien Delcroix commented on patch set 3 03/03/25, 16:09

    No problem Andreas :) As I see, I was far from a really and easiest fix that could be !