Review main Merged

86593[BUGFIX] Reestablish manipulation of EXT:indexed_search query

Oli Bartsch CR +2 V +2 Normal +160 −30 updated 10/18/24, 17:10

Commit message

Due to huge performance implications on
searching bigger sites, it's now possible
again to manipulate the QueryBuilder instance,
before the final indexed search query is executed.
This achieved by introducing a new PSR-14 event.

Additionally a @todo is resolved by adjusting
the repository to execute the final query
centrally in `doSearch()`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 2539

Show 714 earlier messages
  1. Oli Bartsch uploaded patch set 1 10/15/24, 07:20

  2. Oli Bartsch uploaded patch set 2 10/15/24, 07:20

  3. Oli Bartsch uploaded patch set 3 10/15/24, 07:22

  4. core-ci voted on patch set 3 V +1 10/15/24, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67798

  5. core-ci voted on patch set 2 V +1 10/15/24, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67797

  6. core-ci voted on patch set 1 V -1 10/15/24, 07:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67796

  7. Oli Bartsch uploaded patch set 4 V +1 10/15/24, 07:35

  8. core-ci voted on patch set 4 V +1 10/15/24, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67801

  9. Oli Bartsch uploaded patch set 5 V +1 10/15/24, 08:49

  10. Oli Bartsch uploaded patch set 6 10/15/24, 08:51

  11. Oli Bartsch uploaded patch set 7 10/15/24, 09:00

  12. core-ci voted on patch set 5 V -1 10/15/24, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67814

  13. core-ci voted on patch set 6 V -1 10/15/24, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67815

  14. core-ci voted on patch set 7 V -1 10/15/24, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67820

  1. Oli Bartsch uploaded patch set 8 V -1 10/15/24, 09:26

  2. core-ci voted on patch set 8 V +1 10/15/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67824

  3. Anja Leichsenring commented on patch set 9 V +1 10/16/24, 06:53

    Published edit on patch set 8.
  4. Anja Leichsenring voted on patch set 9 CR +1 V +1 10/16/24, 06:56

  5. core-ci voted on patch set 9 V -1 10/16/24, 07:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67869

  6. Garvin Hicking updated the commit message in patch set 10 CR +1 V +1 10/16/24, 18:26

  7. Garvin Hicking commented on patch set 11 10/16/24, 18:27

    Published edit on patch set 10.
  8. core-ci voted on patch set 11 V +1 10/16/24, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67893

  9. core-ci voted on patch set 10 V -1 10/16/24, 18:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67892

  10. Garvin Hicking commented on patch set 11 CR +1 V +1 10/16/24, 18:49

    Could you adjust the commit message/
  11. Christian Kuhn commented on patch set 11 10/17/24, 10:55

    Important-105007-ManipulationOfFinalSearchQueryInEXTindexed_search.rst:28

    I think we need at least a "disclaimer" here, probably in the code/event as well: The main query needs to stay under core control, core needs to be able to change it. When this event is used, and core changes the query to for instance improve performance or when db schema is changed, such a change should not be considered breaking change due to this event. In turn, this event is like: "If you really need it, it may still break with any core release if you are unlucky" or something like that, since core must retain freedom to change things in this area if needed, otherwise the query is doomed to stay in its current form forever, which would be uncool from core point of view.
  12. Christian Kuhn commented on patch set 11 10/17/24, 10:58

    Important-105007-ManipulationOfFinalSearchQueryInEXTindexed_search.rst:28 Reply

    with this being said, i'm not *that* happy with a low level event that is able to change details of queries since they are always a headache when core wants to change something. we could postulate the scenario away, but it would be worth looking at the code to see if there is maybe some different solution (didn't look & think about something, though).
  13. Oli Bartsch commented on patch set 11 10/17/24, 14:48

    Important-105007-ManipulationOfFinalSearchQueryInEXTindexed_search.rst:28 Reply

    Unsure. Actually, we removed ways to optimise the query for use cases by saying "If you still encounter issues, it is recommended to extend Indexed Search queries with custom hooks to manipulate the search query." Then we removed those hooks. IMO adding back ways to optimise the search for custom use cases is the best we can do for developers. We can never get an "optimised" query which will suite every use case out there. Therefore, I suggest to add this event together with - as you suggested - a big disclaimer.
  14. Oli Bartsch uploaded patch set 12 CR +1 V +1 10/18/24, 10:05

  15. Oli Bartsch commented on patch set 12 10/18/24, 10:05

    Important-105007-ManipulationOfFinalSearchQueryInEXTindexed_search.rst:28 Reply

    Done
  16. core-ci voted on patch set 12 V +1 10/18/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67948

  17. Garvin Hicking commented on patch set 13 V +1 10/18/24, 12:21

    Published edit on patch set 12.
  18. core-ci voted on patch set 13 V +1 10/18/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67955

  19. Garvin Hicking commented on patch set 13 CR +1 V +1 10/18/24, 13:08

    Works for me, I think there's a valid need to manipulate the search query.
  20. Benni Mack updated the commit message in patch set 14 CR +1 V +1 10/18/24, 13:34

  21. Benni Mack voted on patch set 14 CR +1 V +1 10/18/24, 13:34

  22. Garvin Hicking voted on patch set 14 CR +1 V +1 10/18/24, 13:35

  23. core-ci voted on patch set 14 V +1 10/18/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67997

  24. Oli Bartsch voted on patch set 14 CR +2 V +2 10/18/24, 17:10

  25. Oli Bartsch merged patch set 15 10/18/24, 17:10