Review main Merged

86605[BUGFIX] Render constants in tags in TypoScript BE modules

Christian Kuhn CR +2 V +2 Easy +1 −3 updated 10/17/24, 10:49

Commit message

FineDiffViewHelper is used in Page TSconfig and TypoScript
"active" modules. That view helper switched from using
FineDiff directly to the core facade DiffUtility with #104325,
and added strip_tags() to the to-diff values.
When constants are used within TypoScript that looks like a
HTML tag, those are now stripped away, ending up with empty
"Constant usage:" rendering in the modules.

The patch fixes the view helper and activates output escaping
to be on the safe side.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Lina Wolf +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 910

  1. Christian Kuhn uploaded patch set 1 10/15/24, 10:55

  2. Christian Kuhn commented on patch set 1 10/15/24, 10:58

    see issue for a straight how-to-reproduce scenario.
  3. Garvin Hicking voted on patch set 1 CR +1 V +1 10/15/24, 11:02

  4. core-ci voted on patch set 1 V +1 10/15/24, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67834

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 10/16/24, 06:49

  6. Lina Wolf commented on patch set 1 V +1 10/16/24, 11:24

    Works fine with my examples. i don't understand the context of the code well enough to review it.
  7. Andreas Kienast voted on patch set 1 CR +1 10/16/24, 13:24

  8. Andreas Kienast voted on patch set 1 V +1 10/17/24, 08:12

  9. Christian Kuhn voted on patch set 1 CR +2 V +2 10/17/24, 10:48

  10. Christian Kuhn merged patch set 2 10/17/24, 10:49