Review main Merged

86607[BUGFIX] Skip non-existant content elements in widget

André Buchmann CR +2 V +2 Easy +10 −2 updated 10/17/24, 08:08

Commit message

Return early on empty contentRecord result. This state can happen
when a content element is deleted and cleaned with the recycler.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. André Buchmann uploaded patch set 1 10/15/24, 14:06

  2. core-ci voted on patch set 1 V +1 10/15/24, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67841

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 10/15/24, 14:53

    Good one! Note that 13.4 is not branched yet; if this should get merged before, "main" will suffice. (I would prefer a 'nullable' return here instead of returning '0' but that would technically be a breaking change now, so 'return 0' is an understandable compromise)
  4. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 10/15/24, 19:57

  5. core-ci voted on patch set 2 V +1 10/15/24, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67851

  6. Garvin Hicking commented on patch set 2 10/16/24, 11:03

    Reply

    I was hinted at the affected method being private, so we should be able to use `?int` here and a null return, maybe you can try to change this?
  7. Andreas Kienast commented on patch set 2 10/16/24, 11:05

    LatestChangedPagesWidget.php:229

    This should add `TYPO3\CMS\Core\Database\Query\Restriction\DeletedRestriction` again.

    LatestChangedPagesWidget.php:236

    This should add `TYPO3\CMS\Core\Database\Query\Restriction\DeletedRestriction` again.
  8. Andreas Kienast uploaded patch set 3 V +1 10/16/24, 11:10

  9. Andreas Kienast commented on patch set 3 10/16/24, 11:11

    Reply

    Done

    LatestChangedPagesWidget.php:229 Reply

    Done

    LatestChangedPagesWidget.php:236 Reply

    Done
  10. core-ci voted on patch set 3 V +1 10/16/24, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67879

  11. Garvin Hicking voted on patch set 3 CR +1 V +1 10/16/24, 11:43

  12. André Buchmann voted on patch set 3 CR +1 V +1 10/16/24, 17:32

  13. Andreas Kienast updated the commit message in patch set 4 CR +1 V +1 10/17/24, 07:58

  14. Garvin Hicking voted on patch set 4 CR +1 V +1 10/17/24, 07:59

  15. core-ci voted on patch set 4 V +1 10/17/24, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67909

  16. Andreas Kienast voted on patch set 4 CR +2 V +2 10/17/24, 08:08

  17. Andreas Kienast merged patch set 5 10/17/24, 08:08