Review main Merged

86609[TASK] Use cache busting for RTE contentCss files

Daniel Siepmann CR +2 V +2 Normal +138 −1 updated 04/11/25, 16:34

Commit message

Properly add version number to contentCss files if configured for the
system.
That way changes to those files are auto loaded by the browser. No more
need to flush the caches.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2231

Show 56 earlier messages
  1. Daniel Siepmann uploaded patch set 1 10/16/24, 09:25

  2. core-ci voted on patch set 1 V +1 10/16/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67872

  3. Benjamin Franzke commented on patch set 1 CR -1 10/16/24, 09:53

    `contentCss` currently allows absolute URLs (with respective CORS and CSP config), this would break with this approach: ``` editor: config: contentsCss: - "https://mycdn.com/foo.css"; ``` I understand you issue though – we used the following workaround to create versioned RTE css URLs: ``` editor: config: contentsCss: - "EXT:site/Resources/Public/Page/css/rte.css?v=5" ``` We actually had to fix this previously: https://forge.typo3.org/issues/101918 That means, whatever we fix here, we must not break previous workarounds for the same issue. We'd need to apply the hash only if it is a EXT-path (and make sure to not break existing query arguments, which actually worked)
  4. Garvin Hicking commented on patch set 1 10/16/24, 18:08

    Reply

    Sounds like we should also create a test for the various variants and workarounds to establish a baseline?
  5. Garvin Hicking wrote 01/24/25, 19:03

    Topic set to csp
  6. Benni Mack uploaded patch set 2 CR -1 V +1 03/23/25, 09:37

  1. core-ci voted on patch set 2 V +1 03/23/25, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76062

  2. Benni Mack uploaded patch set 3 V +1 04/11/25, 07:23

  3. core-ci voted on patch set 3 V -1 04/11/25, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77495

  4. Benni Mack uploaded patch set 4 V -1 04/11/25, 07:42

  5. core-ci voted on patch set 4 V -1 04/11/25, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77497

  6. Stefan Bürk uploaded patch set 5 V -1 04/11/25, 11:09

  7. core-ci voted on patch set 5 V +1 04/11/25, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77517

  8. Stefan Bürk uploaded patch set 6 V +1 04/11/25, 11:20

  9. Stefan Bürk uploaded patch set 7 04/11/25, 11:22

  10. core-ci voted on patch set 6 V -1 04/11/25, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77518

  11. core-ci voted on patch set 7 V -1 04/11/25, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77519

  12. Stefan Bürk uploaded patch set 8 V -1 04/11/25, 11:32

  13. core-ci voted on patch set 8 V +1 04/11/25, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77520

  14. Stefan Bürk voted on patch set 8 CR +1 V +1 04/11/25, 11:57

  15. Garvin Hicking commented on patch set 8 04/11/25, 12:29

    RichTextElementTest.php:76

    RTE.default.contentCSS seems to also be settable to a relativ path like "fileadmin/myStylesheet1.css" - should we add two tests for this (once with and without "?") for it as well?!
  16. Benni Mack commented on patch set 8 04/11/25, 12:41

    RichTextElementTest.php:76 Reply

    But then it does not get cache-busted, because the current code only does this for isExtensionPath().
  17. Garvin Hicking commented on patch set 8 04/11/25, 12:50

    RichTextElementTest.php:76 Reply

    yes but then we'd have that format in the expectation and it would be documented its intentionally not busted...
  18. Benni Mack uploaded patch set 9 CR +1 V +1 04/11/25, 14:09

  19. Benni Mack commented on patch set 8 04/11/25, 14:10

    RichTextElementTest.php:76 Reply

    Done
  20. core-ci voted on patch set 9 V +1 04/11/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77541

  21. Benni Mack voted on patch set 9 CR +1 V +1 04/11/25, 14:23

  22. Benjamin Franzke voted on patch set 9 CR +1 04/11/25, 14:31

  23. Garvin Hicking commented on patch set 9 CR +1 V +1 04/11/25, 16:07

    ty
  24. Benni Mack voted on patch set 9 CR +2 V +2 04/11/25, 16:34

  25. Benni Mack merged patch set 10 04/11/25, 16:34