86609[TASK] Use cache busting for RTE contentCss files
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2231
Show 56 earlier messages
-
Daniel Siepmann uploaded patch set 1 10/16/24, 09:25
-
core-ci voted on patch set 1 V +1 10/16/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67872
-
Benjamin Franzke commented on patch set 1 CR -1 10/16/24, 09:53
`contentCss` currently allows absolute URLs (with respective CORS and CSP config), this would break with this approach: ``` editor: config: contentsCss: - "https://mycdn.com/foo.css" ``` I understand you issue though – we used the following workaround to create versioned RTE css URLs: ``` editor: config: contentsCss: - "EXT:site/Resources/Public/Page/css/rte.css?v=5" ``` We actually had to fix this previously: https://forge.typo3.org/issues/101918 That means, whatever we fix here, we must not break previous workarounds for the same issue. We'd need to apply the hash only if it is a EXT-path (and make sure to not break existing query arguments, which actually worked) -
Garvin Hicking commented on patch set 1 10/16/24, 18:08
Reply
Sounds like we should also create a test for the various variants and workarounds to establish a baseline? -
Garvin Hicking wrote 01/24/25, 19:03
Topic set to csp -
Benni Mack uploaded patch set 2
CR -1V +103/23/25, 09:37
-
core-ci voted on patch set 2 V +1 03/23/25, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76062
-
Benni Mack uploaded patch set 3
V +104/11/25, 07:23 -
core-ci voted on patch set 3 V -1 04/11/25, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77495
-
Benni Mack uploaded patch set 4
V -104/11/25, 07:42 -
core-ci voted on patch set 4 V -1 04/11/25, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77497
-
Stefan Bürk uploaded patch set 5
V -104/11/25, 11:09 -
core-ci voted on patch set 5 V +1 04/11/25, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77517
-
Stefan Bürk uploaded patch set 6
V +104/11/25, 11:20 -
Stefan Bürk uploaded patch set 7 04/11/25, 11:22
-
core-ci voted on patch set 6 V -1 04/11/25, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77518
-
core-ci voted on patch set 7 V -1 04/11/25, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77519
-
Stefan Bürk uploaded patch set 8
V -104/11/25, 11:32 -
core-ci voted on patch set 8 V +1 04/11/25, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77520
-
Stefan Bürk voted on patch set 8 CR +1 V +1 04/11/25, 11:57
-
Garvin Hicking commented on patch set 8 04/11/25, 12:29
RichTextElementTest.php:76RTE.default.contentCSS seems to also be settable to a relativ path like "fileadmin/myStylesheet1.css" - should we add two tests for this (once with and without "?") for it as well?! -
Benni Mack commented on patch set 8 04/11/25, 12:41
RichTextElementTest.php:76ReplyBut then it does not get cache-busted, because the current code only does this for isExtensionPath(). -
Garvin Hicking commented on patch set 8 04/11/25, 12:50
RichTextElementTest.php:76Replyyes but then we'd have that format in the expectation and it would be documented its intentionally not busted... -
Benni Mack uploaded patch set 9
CR +1V +104/11/25, 14:09 -
Benni Mack commented on patch set 8 04/11/25, 14:10
RichTextElementTest.php:76ReplyDone -
core-ci voted on patch set 9 V +1 04/11/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77541
-
Benni Mack voted on patch set 9 CR +1 V +1 04/11/25, 14:23
-
Benjamin Franzke voted on patch set 9 CR +1 04/11/25, 14:31
-
Garvin Hicking commented on patch set 9 CR +1 V +1 04/11/25, 16:07
ty -
Benni Mack voted on patch set 9 CR +2 V +2 04/11/25, 16:34
-
Benni Mack merged patch set 10 04/11/25, 16:34