Review main Merged

86632[BUGFIX] Adjust displayed ENABLE_INSTALL_TOOL legacy install location

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 10/25/24, 09:17

Commit message

The backend screen that shows the "Create an enable install tool file"
message was adapted in #104126, mainly aimed for composer-mode.

Instead of pointing to "typo3conf/" it was also adjusted to "config/".

This patch restores the displayed target directory for an
ENABLE_INSTALL_TOOL file to "typo3conf/". In composer-mode, it
will point to "var/transient/".

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1013

  1. Garvin Hicking uploaded patch set 1 10/16/24, 16:47

  2. Garvin Hicking commented on patch set 1 10/16/24, 16:51

    I'm sorry, I took a wrong turn when reading the comment https://review.typo3.org/c/Packages/TYPO3.CMS/+/84729/comment/3667197b_f214fa6c/ - I did not recognize my mistake here, that what Helmut and Mathias hinted at, was in fact right on track, and I confused the "project path = public path" discussion. Luckily this should "just" be a display matter, but still it needs fixing. 🥺
  3. Garvin Hicking updated the commit message in patch set 2 10/16/24, 16:53

  4. core-ci voted on patch set 1 V +1 10/16/24, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67890

  5. core-ci voted on patch set 2 V +1 10/16/24, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67891

  6. Torben Hansen voted on patch set 2 CR +1 V +1 10/17/24, 07:51

  7. Markus Klein voted on patch set 2 CR +1 V +1 10/17/24, 10:02

  8. Benjamin Franzke updated the commit message in patch set 3 CR +1 V +1 10/25/24, 07:08

  9. Benjamin Franzke voted on patch set 3 CR +1 V +1 10/25/24, 07:09

  10. core-ci voted on patch set 3 V +1 10/25/24, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68582

  11. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/25/24, 07:40

  12. Andreas Kienast voted on patch set 3 CR +2 V +2 10/25/24, 09:05

  13. Andreas Kienast merged patch set 4 10/25/24, 09:17