Review 12.4 Abandoned

86633[BUGFIX] Ensure clean context for f:cObject viewhelper

Markus Klein CR +1 V +1 Easy +1 −1 updated 05/04/26, 13:24

Commit message

The viewhelper passes the current request on to
the ContentObjectRenderer. The request can be
an Extbase request, which causes subsequent
content rendering to fail, due to mangled controller/action
parameters.

The viewhelper must not pass along Extbase stuff,
so this patch removes the extbase attribute on
the request passed on to the ContentObjectRenderer.

Review

  • Code review CR +1
    • Georg Ringer +1
  • Verified V +1
    • Georg Ringer +1
    • Tobias Liebig +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1520

  1. Markus Klein uploaded patch set 1 10/17/24, 07:14

  2. core-ci voted on patch set 1 V +1 10/17/24, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67906

  3. Markus Klein marked it ready for review 10/29/24, 15:22

  4. Markus Klein updated the commit message in patch set 2 V +1 10/29/24, 15:23

  5. core-ci voted on patch set 2 V +1 10/29/24, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68794

  6. Benjamin Franzke marked it work in progress 10/29/24, 17:41

  7. Markus Klein updated the commit message in patch set 3 V +1 03/17/25, 19:55

  8. Markus Klein commented on patch set 3 03/17/25, 19:55

    This change is ready for review.
  9. Markus Klein commented on patch set 3 CR -1 03/17/25, 20:00

    Unresolved

    I'm double-checking the behavior again in v13, when there is no FluidTemplate "inbetween".
  10. core-ci voted on patch set 3 V -1 03/17/25, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75737

  11. Markus Klein commented on patch set 3 CR 0 03/17/25, 20:35

    v13 is indeed not affected, while it still passes along the extbase-attribute
  12. core-ci commented on patch set 3 03/17/25, 20:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75737

  13. Markus Klein rebased onto patch set 4 V -1 03/18/25, 07:56

  14. core-ci voted on patch set 4 V +1 03/18/25, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75760

  15. Tobias Liebig voted on patch set 4 V +1 04/16/25, 14:14

  16. Georg Ringer voted on patch set 4 CR +1 V +1 10/09/25, 18:30

  17. Stefan Bürk commented on patch set 4 CR -1 10/10/25, 13:21

    Reviewing ....
  18. Stefan Bürk commented on patch set 4 CR 0 10/13/25, 15:31

    Reply

    Did not found the time to review yet. Not sure about this and if it would still applicable to do that in main/13.4 even without impact. Exbase context should not be transported up in any case I guess. Not going to block that for now, but also not sure if we should do that in 12.4 only. Hope that someone else finds time to investigate that deeper.
  19. Markus Klein commented on patch set 4 10/14/25, 07:48

    Reply

    We did test on v13, as noted earlier here, but we can simply try again with ext:news, see https://github.com/georgringer/news/issues/2629
  20. Benni Mack abandoned the change 05/04/26, 13:24

    support for 12.4 version in the free version has been dropped.