86634[DOCS] Add details for CSS-prefixing in EXT:rte_ckeditor
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Andreas Nedbal +1
- Sebastian Klein +1
-
Verified V +2 Done
- Garvin Hicking +2
- Andreas Nedbal +1
- Sebastian Klein +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1114
-
Garvin Hicking uploaded patch set 1 10/17/24, 07:37
-
core-ci voted on patch set 1 V +1 10/17/24, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67907
-
Sebastian Klein commented on patch set 1 10/17/24, 10:13
Reference.rst:82Proposal (see above): second line with - "EXT:my_sitepackage/Resources/Public/Css/project-rte.css"Reference.rst:111We currently have at least - "EXT:my_site/…", - "EXT:sitepackage/…", - "EXT:my_sitepackage/…", and - "EXT:my_site_package/…" used for examples in the Core. Would be good to use one of these extension names (and maybe agree on one example extension name later). -
Garvin Hicking commented on patch set 2
V +110/17/24, 10:23Published edit on patch set 1. -
Garvin Hicking commented on patch set 1 10/17/24, 10:24
Reference.rst:77ReplyYes, good idea. Done. Also rephrased it a bit.Reference.rst:82ReplyDoneReference.rst:111ReplyAck. At least it's unified in this document, but this is a cleanup that needs to be done (with its own patch though). This will be a tedious effort though... -
core-ci voted on patch set 2 V +1 10/17/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67914
-
Sebastian Klein commented on patch set 2 10/17/24, 11:21
Reference.rst:77Minor typo in "containing" -
Garvin Hicking commented on patch set 3
V +110/17/24, 12:42Published edit on patch set 2. -
Garvin Hicking commented on patch set 3 10/17/24, 12:42
Reference.rst:77ReplyDone -
core-ci voted on patch set 3 V +1 10/17/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67918
-
Sebastian Klein voted on patch set 3 CR +1 V +1 10/17/24, 13:09
-
Andreas Nedbal voted on patch set 3 CR +1 V +1 10/18/24, 09:20
-
Garvin Hicking voted on patch set 3 CR +2 V +2 10/18/24, 13:25
-
Garvin Hicking merged patch set 4 10/18/24, 13:25
Reference.rst:77