Review main Work in progress Orphaned

86637[TASK] Prevent "id" parameter in backend URLs if not passed

TYPO3com CR 0 V -1 Easy +0 −5 updated 03/28/25, 12:10

Commit message

In TYPO3 v13, namespaced URL GET parameters are not supported any more and
the URLs look like "/typo3/module/web/aimeos/Jsonadm/index?token=...".

If the Extbase plugin uses an "id" parameter to identify a record, this
"id" parameter will be added by buildBackendUri() to all links generated
for that request, even if the generated links must not include an "id"
parameter, e.g. when searching in repositories and the "id" parameter is
used to switch between retrieving a single item and retrieving a list of
items.

This behavior seems to be a left-over from previous TYPO3 versions.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/86637/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/86637/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 1

Files 1

Review log 35

  1. TYPO3com uploaded patch set 1 10/17/24, 10:12

  2. core-ci voted on patch set 1 V -1 10/17/24, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67913

  3. Christian Kuhn commented on patch set 1 10/17/24, 10:46

    Unresolved

    Warning: The 'id' argument plays a special role in parts of BE core and extbase: It is interpreted as "page uid" (the selected page tree page) in various cases, for instance in extbase BackendConfigurationManager to fetch page specific FE TS (SIC!). Permissions stuff relies on it as well, IIRC. In file tree, it is the storage-uid:path identifier, though. Read: Tampering with 'id' argument is fiddly and needs good testing to verify it does not break something.
  4. Benni Mack wrote 03/28/25, 12:10

    Hashtag added: lolli-feedback
  5. Benni Mack marked it work in progress 03/28/25, 12:10