Review main Merged

86638[BUGFIX] Ensure runtime cache is shared between CacheManager and DI

Benjamin Franzke CR +2 V +2 Easy +1 −0 updated 10/18/24, 08:13

Commit message

The `cache.runtime` service delivered via DI is to be
shared with the `runtime` cache generated by CacheManager,
as all caches are intended to be shared between these two containers.
`cache.runtime` was missed to be marked as default cache in
the CacheManager service provider.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 69

  1. Benjamin Franzke uploaded patch set 1 10/17/24, 11:40

  2. Benjamin Franzke voted on patch set 1 CR -1 10/17/24, 11:40

  3. core-ci voted on patch set 1 V +1 10/17/24, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67915

  4. Benjamin Franzke uploaded patch set 2 CR -1 V +1 10/17/24, 13:36

  5. core-ci voted on patch set 2 V -1 10/17/24, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67923

  6. core-ci voted on patch set 2 V +1 10/18/24, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67923

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 10/18/24, 07:50

  8. Andreas Kienast voted on patch set 2 CR +2 V +2 10/18/24, 08:13

  9. Andreas Kienast merged patch set 3 10/18/24, 08:13