Review main Merged

86640[BUGFIX] Properly scan for breaking GU::sanitizeLocalUrl() change

Torben Hansen CR +2 V +2 Easy +7 −7 updated 10/17/24, 13:27

Commit message

With #101311 the function argument for
`GeneralUtility::sanitizeLocalUrl` has been declared as required.
The breaking change is however not detected by extension scanner,
because the associated extension scanner configuration has been
added to `MethodArgumentRequiredMatcher.php`. Since the changed
function is static, the correct file for the extension scanner
configuration is `MethodArgumentRequiredStaticMatcher.php`.

This change moves the associated extension scanner configuration
to the correct file.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Torben Hansen uploaded patch set 1 10/17/24, 12:39

  2. core-ci voted on patch set 1 V +1 10/17/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67917

  3. Mathias Brodala updated the commit message in patch set 2 V +1 10/17/24, 12:58

  4. Mathias Brodala voted on patch set 2 CR +1 10/17/24, 12:59

  5. core-ci voted on patch set 2 V +1 10/17/24, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67919

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 10/17/24, 13:14

  7. Benjamin Franzke commented on patch set 2 V -1 10/17/24, 13:16

    does not work for me (trying to debug…)
  8. Benjamin Franzke commented on patch set 2 CR +2 V +2 10/17/24, 13:27

    Reply

    nvm, didn't test properly
  9. Benjamin Franzke merged patch set 3 10/17/24, 13:27