Review main Merged

86641[TASK] Implement ESLint `no-unneeded-ternary` rule

Ayke Halder CR +2 V +2 Easy +3 −2 updated 10/17/24, 13:46

Commit message

The ESLint configuration now takes the rule `no-unneeded-ternary` [1]
into account, prohibiting the use of unnecessary complex conditional
expressions.

[1] https://eslint.org/docs/latest/rules/no-unneeded-ternary

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Ayke Halder uploaded patch set 1 10/17/24, 13:26

  2. Benjamin Franzke updated the commit message in patch set 2 10/17/24, 13:28

  3. Benjamin Franzke voted on patch set 2 CR +1 V +1 10/17/24, 13:32

  4. core-ci voted on patch set 1 V +1 10/17/24, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67920

  5. core-ci voted on patch set 2 V +1 10/17/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67921

  6. Benjamin Kott voted on patch set 2 CR +1 V +1 10/17/24, 13:46

  7. Benjamin Franzke voted on patch set 2 CR +2 V +2 10/17/24, 13:46

  8. Benjamin Franzke merged patch set 3 10/17/24, 13:46