Review main Merged

86642[TASK] Move record list specific actions from AjaxDataHandler

Andreas Kienast CR +2 V +2 Hard +174 −227 updated 02/19/25, 10:54

Commit message

Since its introduction, the module `AjaxDataHandler` implemented event
handlers for (un)hiding or deleting records, triggered from the record
list. This is a long standing design issue as AjaxDataHandler and record
list were tightly coupled.

This patch aims to separate the concerns – record list specific methods
are moved into the record list domain, making the event handlers
private.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 3546

Show 1621 earlier messages
  1. Andreas Kienast uploaded patch set 1 10/17/24, 13:38

  2. core-ci voted on patch set 1 V -1 10/17/24, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67925

  3. Benni Mack commented on patch set 1 01/31/25, 18:37

    RecordListController.php:238

    "manadatory" => "mandatory"
  4. Daniel Windloff commented on patch set 1 02/02/25, 11:57

    RecordListController.php:231

    I suggest toggleRecordVisibilityAction

    RecordListController.php:238

    $action hasn't been checked in isset.

    RecordListController.php:245

    Check for $this->tcaSchemaFactory->has($table); with exception is missing.
  5. Andreas Kienast commented on patch set 1 02/03/25, 14:44

    RecordListController.php:231 Reply

    Acknowledged

    RecordListController.php:238 Reply

    Acknowledged

    RecordListController.php:238 Reply

    Acknowledged

    RecordListController.php:245 Reply

    Acknowledged
  6. Andreas Kienast uploaded patch set 2 V -1 02/03/25, 15:23

  7. core-ci voted on patch set 2 V +1 02/03/25, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73416

  8. Andreas Kienast uploaded patch set 3 V +1 02/11/25, 15:01

  9. core-ci voted on patch set 3 V +1 02/11/25, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73995

  10. Georg Ringer commented on patch set 3 02/12/25, 09:59

    RecordListController.php:272

    why not using BackendUtility::getRecord?

    RecordListController.php:285

    I guess this could fail if the record has not been found?
  11. Andreas Kienast commented on patch set 3 02/12/25, 10:25

    RecordListController.php:272 Reply

    I have no strong opinion here.

    RecordListController.php:285 Reply

    Honestly, at this point I'd expect DataHandler to fail before. This should be checked before, then.
  12. Andreas Kienast uploaded patch set 4 V +1 02/12/25, 15:59

  13. Andreas Kienast commented on patch set 4 02/12/25, 16:00

    RecordListController.php:272 Reply

    Done
  14. Andreas Kienast uploaded patch set 5 02/12/25, 16:00

  15. Andreas Kienast uploaded patch set 6 02/12/25, 16:05

  16. Andreas Kienast commented on patch set 5 02/12/25, 16:05

    RecordListController.php:285 Reply

    Done
  17. core-ci voted on patch set 4 V +1 02/12/25, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74046

  18. core-ci voted on patch set 6 V +1 02/12/25, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74048

  19. Andreas Kienast uploaded patch set 7 V +1 02/13/25, 07:23

  20. Andreas Kienast commented on patch set 7 02/13/25, 07:24

    I've extracted the record toggle change with its dedicated controller action into a new patch, as it's not directly related to the breaking change.
  21. Andreas Kienast uploaded patch set 8 02/13/25, 07:26

  1. core-ci voted on patch set 7 V +1 02/13/25, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74099

  2. core-ci voted on patch set 8 V +1 02/13/25, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74101

  3. Anja Leichsenring voted on patch set 8 CR +1 V +1 02/13/25, 10:31

  4. Andreas Kienast uploaded patch set 9 CR +1 V +1 02/18/25, 15:05

  5. Andreas Kienast commented on patch set 9 02/18/25, 15:07

    After discussing this patch with @ben@bnf.dev, we came to the conclusion it is not a breaking change. Developers are advised to use the `f:be.tableList` view helper, which is still functional.
  6. core-ci voted on patch set 9 V +1 02/18/25, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74327

  7. Benjamin Franzke commented on patch set 9 02/18/25, 15:25

    ajax-data-handler.ts:37

    Method is now unused and can be removed
  8. Benjamin Franzke uploaded patch set 10 V +1 02/18/25, 15:26

  9. Benjamin Franzke commented on patch set 10 02/18/25, 15:26

    ajax-data-handler.ts:37 Reply

    Done
  10. core-ci voted on patch set 10 V -1 02/18/25, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74330

  11. Andreas Kienast uploaded patch set 11 V -1 02/18/25, 15:37

  12. Andreas Kienast commented on patch set 11 02/18/25, 15:37

    ajax-data-handler.ts:37 Reply

    Nice catch, I also rebuilt the JavaScript file 😄.
  13. core-ci voted on patch set 11 V +1 02/18/25, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74331

  14. Benjamin Franzke commented on patch set 11 CR +1 V +1 02/18/25, 16:18

    I'd also be fine with 13.4 here, but that's up to you.

    ajax-data-handler.ts:37 Reply

    For some reason `npm run build-js` didn't produce changes for me 😕 Anyway, thx.
  15. Andreas Nedbal voted on patch set 11 CR +1 V +1 02/19/25, 10:31

  16. Simon Schaufelberger commented on patch set 11 02/19/25, 10:35

    recordlist.ts:257

    what if there are errors? Wouldn't it be good to show a notification with the error message?

    recordlist.ts:343

    why is there no error handling check like on the toggle?
  17. Andreas Kienast commented on patch set 11 02/19/25, 10:40

    recordlist.ts:257 Reply

    That would probably be good, but not scope of this patch. There's a follow up patch that reworks record toggling.
  18. Simon Schaufelberger commented on patch set 11 CR +1 V +1 02/19/25, 10:44

    recordlist.ts:343 Reply

    Acknowledged
  19. Andreas Kienast commented on patch set 11 02/19/25, 10:44

    recordlist.ts:343 Reply

    I agree this is missing for the special case that "has errors" is true. IMO this needs rework in `SimpleDataHandlerController` anyway, sending "OK" (Status 200) does not make sense.
  20. Andreas Kienast uploaded patch set 12 CR +1 V +1 02/19/25, 10:45

  21. Andreas Nedbal voted on patch set 12 CR +1 V +1 02/19/25, 10:47

  22. Simon Schaufelberger commented on patch set 12 CR +1 V +1 02/19/25, 10:49

    recordlist.ts:343 Reply

    Done
  23. core-ci voted on patch set 12 V +1 02/19/25, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74369

  24. Andreas Kienast voted on patch set 12 CR +2 V +2 02/19/25, 10:54

  25. Andreas Kienast merged patch set 13 02/19/25, 10:54