86643[BUGFIX] Generate correct overlay icon when hiding record in record list
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Garvin Hicking +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1115
-
Andreas Kienast uploaded patch set 1 10/17/24, 13:59
-
core-ci voted on patch set 1 V +1 10/17/24, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67926
-
Benjamin Franzke commented on patch set 1 10/17/24, 15:25
-
Andreas Kienast commented on patch set 1 CR -1 10/17/24, 15:49
DatabaseRecordList.php:1718ReplyThat‘s true, I was too much focussed on my own test case. -1 for now. -
Andreas Kienast uploaded patch set 2
CR -1V +110/18/24, 06:24 -
core-ci voted on patch set 2 V +1 10/18/24, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67941
-
Andreas Kienast commented on patch set 2 10/18/24, 06:50
DatabaseRecordList.php:1718ReplyDone -
Oliver Hader updated the commit message in patch set 3
V +110/18/24, 13:53 -
core-ci voted on patch set 3 V +1 10/18/24, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68075
-
Oliver Hader rebased onto patch set 4
V +110/31/24, 11:28 -
core-ci voted on patch set 4 V +1 10/31/24, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68912
-
Garvin Hicking commented on patch set 4 CR +1 V +1 11/04/24, 08:45
Mental note: You want to test the direct non-page-reload "hide/unhide" toggle in the record list, in the right bar. Not via the context menu. The context menu does a page reload, this is not test you're looking for. -
Oli Bartsch voted on patch set 4 CR +1 V +1 11/05/24, 15:50
-
Andreas Kienast voted on patch set 4 CR +2 V +2 11/06/24, 06:58
-
Andreas Kienast merged patch set 5 11/06/24, 06:58
DatabaseRecordList.php:1718