Review main Merged

86643[BUGFIX] Generate correct overlay icon when hiding record in record list

Andreas Kienast CR +2 V +2 Easy +18 −11 updated 11/06/24, 06:58

Commit message

When hiding a record in the record list, a placeholder icon with a
hard-coded overlay `overlay-hidden` was generated.
This is the default overlay, unless an event listener for the event
`ModifyRecordOverlayIconIdentifierEvent` is implemented that may
override this.
The overridden icon is correctly shown when initially rendering the
records, but not when visible icons get hidden.

This patch now always generates a dummy icon in a forced hidden state to
get the overlay icon identier, which is then used in the toggle action.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1115

  1. Andreas Kienast uploaded patch set 1 10/17/24, 13:59

  2. core-ci voted on patch set 1 V +1 10/17/24, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67926

  3. Benjamin Franzke commented on patch set 1 10/17/24, 15:25

    DatabaseRecordList.php:1718

    What if the row is currently hidden, then we still don't know the possible overlay for the case when the record is toggled to active. Does this also need `data-datahandler-record-active-overlay-icon`?
  4. Andreas Kienast commented on patch set 1 CR -1 10/17/24, 15:49

    DatabaseRecordList.php:1718 Reply

    That‘s true, I was too much focussed on my own test case. -1 for now.
  5. Andreas Kienast uploaded patch set 2 CR -1 V +1 10/18/24, 06:24

  6. core-ci voted on patch set 2 V +1 10/18/24, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67941

  7. Andreas Kienast commented on patch set 2 10/18/24, 06:50

    DatabaseRecordList.php:1718 Reply

    Done
  8. Oliver Hader updated the commit message in patch set 3 V +1 10/18/24, 13:53

  9. core-ci voted on patch set 3 V +1 10/18/24, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68075

  10. Oliver Hader rebased onto patch set 4 V +1 10/31/24, 11:28

  11. core-ci voted on patch set 4 V +1 10/31/24, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68912

  12. Garvin Hicking commented on patch set 4 CR +1 V +1 11/04/24, 08:45

    Mental note: You want to test the direct non-page-reload "hide/unhide" toggle in the record list, in the right bar. Not via the context menu. The context menu does a page reload, this is not test you're looking for.
  13. Oli Bartsch voted on patch set 4 CR +1 V +1 11/05/24, 15:50

  14. Andreas Kienast voted on patch set 4 CR +2 V +2 11/06/24, 06:58

  15. Andreas Kienast merged patch set 5 11/06/24, 06:58