Review main Abandoned

86644[TASK] Remove validation for "id" parameter in backend

TYPO3com CR 0 V 0 Easy +0 −20 updated 04/09/25, 21:08

Commit message

Since backend module parameters are not namespaced any more in v12/v13,
the "id" parameter can not be treated as page ID any more because extbase
extensions use "id" to identify own records.

The problem occurs in v12 because there, namespaced and non-namespaced
configurations are supported. In Extbase extensions using non-namespaced
parameters, the "id" parameter is still validated as backend page ID even
if it's an Extbase module identifier.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 46

  1. TYPO3com uploaded patch set 1 10/17/24, 14:46

  2. core-ci voted on patch set 1 V -1 10/17/24, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67927

  3. Oli Bartsch commented on patch set 1 10/17/24, 14:57

    Unresolved

    I agree that this is a problem but we can not just remove the handling but have to replace it with a proper solution.
  4. Oli Bartsch voted on patch set 1 V -1 10/17/24, 14:57

  5. Benni Mack commented on patch set 1 04/09/25, 21:08

    if we remove this part, every module expecting the page to be handed as id parameter (= 80%) will not work anymore. Right now "id" is a protected parameter, just as "id", "type" and "cHash" are in the frontend. We cannot overcome this currently, until we have slugs in BE modules or determine meaning to GET parameters (= page or not) in routes
  6. Benni Mack abandoned the change 04/09/25, 21:08

    can't do