Review main Merged

86645[BUGFIX] Avoid deprecated call in install IconController

Benjamin Franzke CR +2 V +2 Easy +2 −0 updated 10/18/24, 07:53

Commit message

The icon API has been refactored to use an enum in #101475,
but the install tool IconController missed to convert a
size string to an enum.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 10/17/24, 19:54

  2. core-ci voted on patch set 1 V +1 10/17/24, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67928

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 10/18/24, 06:50

  4. Anja Leichsenring voted on patch set 1 CR +1 V +1 10/18/24, 07:51

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 10/18/24, 07:53

  6. Andreas Kienast merged patch set 2 10/18/24, 07:53