Review main Merged

86648[DOCS] Initialize Changelog structure for v14.0-dev

Garvin Hicking CR +2 V +2 Normal +67 −0 updated 10/21/24, 12:16

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1316

  1. Garvin Hicking uploaded patch set 1 10/18/24, 15:05

  2. Garvin Hicking updated the commit message in patch set 2 10/18/24, 15:06

  3. Garvin Hicking rebased onto patch set 3 10/19/24, 17:43

  4. core-ci voted on patch set 3 V +1 10/19/24, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68231

  5. Chris Müller commented on patch set 3 10/19/24, 18:57

    Changelog-14.rst:1

    Why orphan instead of adding it to the Documentation/Index.rst?

    Changelog-14.rst:3

    Would you like to indent with one more space?

    Index.rst:2

    Would you like to indext with one more space? Also below.
  6. Garvin Hicking commented on patch set 4 V +1 10/19/24, 19:16

    Published edit on patch set 3.
  7. Garvin Hicking uploaded patch set 5 10/19/24, 19:17

  8. Garvin Hicking commented on patch set 4 10/19/24, 19:18

    Changelog-14.rst:1 Reply

    Copy + paste. All the others have that orphan, too - I don't know what it does but know it works with that. However, I forgot to add the main Index.rst which lists this file - thanks! I'd probably keep it like that, and we can do a follow-up patch to sort out the orphans on a distinct patch, wdyt?

    Changelog-14.rst:3 Reply

    Done

    Index.rst:2 Reply

    Done
  9. core-ci voted on patch set 4 V +1 10/19/24, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68234

  10. core-ci voted on patch set 5 V +1 10/19/24, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68235

  11. Chris Müller commented on patch set 5 10/20/24, 04:34

    Changelog-14.rst:1 Reply

    orphan means, that there are no warning from the docs generator when the file is not listed in a menu (to mark that it is intentional that the file is not referenced). So, as it is listed in the menu, no orphan needed.
  12. Garvin Hicking commented on patch set 5 10/20/24, 07:57

    Changelog-14.rst:1 Reply

    Alright. Let's change that for all then in a diatinct follow-up commit.
  13. Chris Müller voted on patch set 5 CR +1 V +1 10/20/24, 18:11

  14. Garvin Hicking commented on patch set 5 10/20/24, 18:36

    (waiting for main to get marked as 14.0-dev)
  15. Christian Kuhn voted on patch set 5 CR +2 V +2 10/21/24, 12:16

  16. Christian Kuhn merged patch set 6 10/21/24, 12:16