Review 13.4 Merged

86649[DOCS] Use 13.4 release for extension Documentation

Garvin Hicking CR +2 V +2 Normal +77 −77 updated 10/19/24, 17:40

Commit message

This is only needed for the 13.4 branch and is required
so that docs.typo3.org can render the 13.4 documentation
based off that branch.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 1011

  1. Garvin Hicking uploaded patch set 1 10/18/24, 15:19

    Init
  2. Benjamin Franzke commented on patch set 1 CR -1 10/18/24, 15:38

    s9y?
  3. Garvin Hicking updated the commit message in patch set 2 CR -1 10/18/24, 16:11

  4. Garvin Hicking commented on patch set 2 10/18/24, 16:12

    Reply

    Haha muscle memory, sorry. Adjusted.
  5. Chris Müller commented on patch set 2 10/19/24, 04:22

    On 12.4, typo3-core-preferred is set to 12.4, here to 13. Why the difference (and not 13.4)? https://github.com/TYPO3/typo3/blob/12.4/typo3/sysext/adminpanel/Documentation/guides.xml#L13
  6. Lina Wolf commented on patch set 2 10/19/24, 05:36

    Reply

    13 will be resolved to 13.4 once all manuals have a 13.4 branch. 13.4 would break if some manuals are still missing. To use 13 is therefore safer but there is no reason to chahnge this backwards.
  7. Lina Wolf commented on patch set 2 CR +1 V +1 10/19/24, 05:36

    Looks good!
  8. Chris Müller voted on patch set 2 CR +1 V +1 10/19/24, 17:03

  9. core-ci voted on patch set 2 V +1 10/19/24, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68196

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 10/19/24, 17:40

  11. Stefan Bürk merged patch set 3 10/19/24, 17:40