Review main Merged

86651[DOCS] Add example for rendering record objects in PAGEVIEW

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 10/25/24, 08:14

Commit message

Usually, the existing rendering definition is used for rendering
Content Elements, instead of building it manually in the page template.
The example is changed to use the f:cObject ViewHelper, which makes
use of already available information for table, record type and
the raw record.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Nikita Hovratov uploaded patch set 1 10/18/24, 15:57

  2. Nikita Hovratov uploaded patch set 2 10/24/24, 16:12

  3. core-ci voted on patch set 2 V +1 10/24/24, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68564

  4. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/25/24, 07:44

  5. Benni Mack voted on patch set 2 CR +2 V +2 10/25/24, 07:49

  6. Benni Mack merged patch set 3 10/25/24, 07:49

  7. Karsten Nowak commented on patch set 3 10/25/24, 08:02

    Feature-103894-AdditionalPropertiesForColumnsInPageLayouts.rst:100

    Is it necessary to use the `{record.fyllType}` for the `typoScriptObjectPath`? If the CType is not defined in TS that will break the whole page rendering with an exception. Can be `{record.mainType}` the better one? Or is that the intended behaviour?
  8. Nikita Hovratov commented on patch set 3 10/25/24, 08:14

    Feature-103894-AdditionalPropertiesForColumnsInPageLayouts.rst:100 Reply Unresolved

    Okay, I see now. When requesting the rendering of just "tt_content", the fallback defined in the CASE cObject is used. Do you want to provide a patch for that?