Review main Merged

86652[BUGFIX] Fix optional site set dependencies

Benjamin Franzke CR +2 V +2 Easy +40 −3 updated 11/04/24, 08:12

Commit message

Prevent a PHP warning when optional dependencies
are not available and ensure that dependencies are
not just ordered, but also pulled in when not
requested directly as part of the site configuration.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Jörg Bösche +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 710

  1. Benjamin Franzke uploaded patch set 1 10/18/24, 17:18

  2. core-ci voted on patch set 1 V -1 10/19/24, 03:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68200

  3. core-ci commented on patch set 1 10/19/24, 06:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68200

  4. Benjamin Franzke rebased onto patch set 2 V -1 10/19/24, 07:32

  5. core-ci voted on patch set 2 V +1 10/19/24, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68219

  6. Andreas Kienast voted on patch set 2 CR +1 V +1 10/26/24, 18:31

  7. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/28/24, 11:54

  8. Jörg Bösche voted on patch set 2 CR +1 11/01/24, 11:17

  9. Benjamin Franzke voted on patch set 2 CR +2 V +2 11/04/24, 08:12

  10. Benjamin Franzke merged patch set 3 11/04/24, 08:12